You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2016/06/27 16:23:52 UTC

[jira] [Commented] (HBASE-16121) Require only MasterServices to the ServerManager constructor

    [ https://issues.apache.org/jira/browse/HBASE-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351350#comment-15351350 ] 

Ted Yu commented on HBASE-16121:
--------------------------------

+1, if tests pass.

> Require only MasterServices to the ServerManager constructor
> ------------------------------------------------------------
>
>                 Key: HBASE-16121
>                 URL: https://issues.apache.org/jira/browse/HBASE-16121
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>    Affects Versions: 2.0.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16121-v0.patch
>
>
> currently we pass Server and MasterServices to the ServerManager. 
> MasterServices is a Server and in tests where we try to pass only one of the two we end up with NPEs if the code change.
> remove the Server arg and just pass the MasterServices



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)