You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/29 10:47:15 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1549: The problem before release rc-3
LaurenceLiZhixin opened a new pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549
- upgreade triple pb generate tool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1549: Upgreade triple pb generate tool
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549#issuecomment-955178560
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1549](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5934f6f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c378031a059b078171edcbc1f3a3b19214486318?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c378031) will **decrease** coverage by `0.19%`.
> The diff coverage is `60.86%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1549 +/- ##
==========================================
- Coverage 41.78% 41.58% -0.20%
==========================================
Files 258 258
Lines 15121 15113 -8
==========================================
- Hits 6318 6285 -33
- Misses 8059 8089 +30
+ Partials 744 739 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `21.62% <ø> (ø)` | |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `55.33% <0.00%> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `24.74% <0.00%> (ø)` | |
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `0.00% <ø> (ø)` | |
| [config/logger\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2xvZ2dlcl9jb25maWcuZ28=) | `47.45% <ø> (ø)` | |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `21.05% <ø> (ø)` | |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <ø> (ø)` | |
| [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `23.37% <50.00%> (+0.87%)` | :arrow_up: |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `65.74% <50.00%> (ø)` | |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `26.85% <70.58%> (-12.04%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c378031...5934f6f](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1549: Upgreade triple pb generate tool
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1549: Upgreade triple pb generate tool
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549#issuecomment-955178560
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1549](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8927105) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/68ac8469ef024b45a84c194e4196bfef19d9c95f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68ac846) will **decrease** coverage by `0.10%`.
> The diff coverage is `48.80%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1549 +/- ##
==========================================
- Coverage 41.83% 41.72% -0.11%
==========================================
Files 258 258
Lines 15111 15114 +3
==========================================
- Hits 6321 6307 -14
- Misses 8057 8068 +11
- Partials 733 739 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cluster/router/v3router/router\_chain.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9yb3V0ZXIvdjNyb3V0ZXIvcm91dGVyX2NoYWluLmdv) | `41.80% <0.00%> (-0.35%)` | :arrow_down: |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `21.62% <ø> (ø)` | |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `55.33% <0.00%> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `24.74% <0.00%> (ø)` | |
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `0.00% <ø> (ø)` | |
| [config/logger\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2xvZ2dlcl9jb25maWcuZ28=) | `47.45% <ø> (ø)` | |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `21.05% <ø> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `24.65% <ø> (ø)` | |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <ø> (ø)` | |
| [config/router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `5.26% <ø> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7f1521c...8927105](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1549: Upgreade triple pb generate tool
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549#issuecomment-955178560
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1549](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (99c30ec) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c378031a059b078171edcbc1f3a3b19214486318?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c378031) will **increase** coverage by `0.15%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head 99c30ec differs from pull request most recent head 5934f6f. Consider uploading reports for the commit 5934f6f to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1549 +/- ##
==========================================
+ Coverage 41.78% 41.94% +0.15%
==========================================
Files 258 258
Lines 15121 15121
==========================================
+ Hits 6318 6342 +24
+ Misses 8059 8039 -20
+ Partials 744 740 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `55.33% <0.00%> (ø)` | |
| [config/logger\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2xvZ2dlcl9jb25maWcuZ28=) | `47.45% <ø> (ø)` | |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `38.88% <0.00%> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `65.74% <50.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `51.62% <0.00%> (+0.97%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `71.91% <0.00%> (+2.24%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+3.70%)` | :arrow_up: |
| [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `37.23% <0.00%> (+12.76%)` | :arrow_up: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+15.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c378031...5934f6f](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #1549: Upgreade triple pb generate tool
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549#discussion_r739576080
##########
File path: go.mod
##########
@@ -13,7 +13,7 @@ require (
github.com/creasty/defaults v1.5.2
github.com/dubbogo/go-zookeeper v1.0.3
github.com/dubbogo/gost v1.11.19
- github.com/dubbogo/triple v1.0.8
+ github.com/dubbogo/triple v1.0.9-0.20211029101533-26805fcfcf62
Review comment:
can you remove commit id？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1549: Upgreade triple pb generate tool
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549#discussion_r739631857
##########
File path: go.mod
##########
@@ -13,7 +13,7 @@ require (
github.com/creasty/defaults v1.5.2
github.com/dubbogo/go-zookeeper v1.0.3
github.com/dubbogo/gost v1.11.19
- github.com/dubbogo/triple v1.0.8
+ github.com/dubbogo/triple v1.0.9-0.20211029101533-26805fcfcf62
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1549: Upgreade triple pb generate tool
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549#issuecomment-955178560
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1549](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (99c30ec) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c378031a059b078171edcbc1f3a3b19214486318?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c378031) will **increase** coverage by `0.15%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head 99c30ec differs from pull request most recent head 9d80416. Consider uploading reports for the commit 9d80416 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1549 +/- ##
==========================================
+ Coverage 41.78% 41.94% +0.15%
==========================================
Files 258 258
Lines 15121 15121
==========================================
+ Hits 6318 6342 +24
+ Misses 8059 8039 -20
+ Partials 744 740 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `55.33% <0.00%> (ø)` | |
| [config/logger\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2xvZ2dlcl9jb25maWcuZ28=) | `47.45% <ø> (ø)` | |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `38.88% <0.00%> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `65.74% <50.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `51.62% <0.00%> (+0.97%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `71.91% <0.00%> (+2.24%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+3.70%)` | :arrow_up: |
| [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `37.23% <0.00%> (+12.76%)` | :arrow_up: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+15.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c378031...9d80416](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1549: Upgreade triple pb generate tool
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1549:
URL: https://github.com/apache/dubbo-go/pull/1549#issuecomment-955178560
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1549](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5934f6f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/68ac8469ef024b45a84c194e4196bfef19d9c95f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68ac846) will **decrease** coverage by `0.24%`.
> The diff coverage is `47.43%`.
> :exclamation: Current head 5934f6f differs from pull request most recent head 8927105. Consider uploading reports for the commit 8927105 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1549 +/- ##
==========================================
- Coverage 41.83% 41.58% -0.25%
==========================================
Files 258 258
Lines 15111 15113 +2
==========================================
- Hits 6321 6285 -36
- Misses 8057 8089 +32
- Partials 733 739 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `21.62% <ø> (ø)` | |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `55.33% <0.00%> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `24.74% <0.00%> (ø)` | |
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `0.00% <ø> (ø)` | |
| [config/logger\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2xvZ2dlcl9jb25maWcuZ28=) | `47.45% <ø> (ø)` | |
| [config/method\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGhvZF9jb25maWcuZ28=) | `21.05% <ø> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `24.65% <ø> (ø)` | |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <ø> (ø)` | |
| [config/router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `5.26% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `9.39% <ø> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/dubbo-go/pull/1549/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7f1521c...8927105](https://codecov.io/gh/apache/dubbo-go/pull/1549?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org