You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ibessonov (via GitHub)" <gi...@apache.org> on 2023/06/19 15:28:39 UTC
[GitHub] [ignite-3] ibessonov opened a new pull request, #2218: IGNITE-19700 Added several optimizations for meta-storage reads.
ibessonov opened a new pull request, #2218:
URL: https://github.com/apache/ignite-3/pull/2218
https://issues.apache.org/jira/browse/IGNITE-19700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov merged PR #2218:
URL: https://github.com/apache/ignite-3/pull/2218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2218:
URL: https://github.com/apache/ignite-3/pull/2218#discussion_r1234918926
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -427,7 +436,7 @@ private void updateKeysIndex(WriteBatch batch, byte[] key, long curRev) {
* @throws RocksDBException If failed.
*/
private void fillAndWriteBatch(WriteBatch batch, long newRev, long newCntr, @Nullable HybridTimestamp ts) throws RocksDBException {
- try (WriteOptions opts = new WriteOptions()) {
+ try (WriteOptions opts = new WriteOptions().setDisableWAL(true)) {
Review Comment:
Could you please leave a comment on why we need (and can) disable the WAL to make it explicit?
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -239,20 +243,25 @@ public void start() {
}
private static List<ColumnFamilyDescriptor> cfDescriptors() {
- Options dataOptions = new Options().setCreateIfMissing(true)
+ Options sharedOptions = new Options()
+ .setCreateIfMissing(true)
+ .setNumLevels(4)
Review Comment:
I think it will be useful to comment the options that were chosen and write a justification for the specific options and values chosen; otherwise, in the future, it will become difficult to remember why the configuration is as it is now.
I'm not sure whether we need to make these configurable by the user. Maybe we should leave the values hard-coded for now as they seem to be very specific to our Meta-Storage scenarios (and the load profile will not necessarily change from cluster to cluster).
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -239,20 +243,25 @@ public void start() {
}
private static List<ColumnFamilyDescriptor> cfDescriptors() {
- Options dataOptions = new Options().setCreateIfMissing(true)
+ Options sharedOptions = new Options()
Review Comment:
BasicOptions/BaseOptions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #2218:
URL: https://github.com/apache/ignite-3/pull/2218#discussion_r1234971871
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -239,20 +243,25 @@ public void start() {
}
private static List<ColumnFamilyDescriptor> cfDescriptors() {
- Options dataOptions = new Options().setCreateIfMissing(true)
+ Options sharedOptions = new Options()
+ .setCreateIfMissing(true)
+ .setNumLevels(4)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2218: IGNITE-19700 Added several optimizations for meta-storage reads.
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #2218:
URL: https://github.com/apache/ignite-3/pull/2218#discussion_r1234962972
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -427,7 +436,7 @@ private void updateKeysIndex(WriteBatch batch, byte[] key, long curRev) {
* @throws RocksDBException If failed.
*/
private void fillAndWriteBatch(WriteBatch batch, long newRev, long newCntr, @Nullable HybridTimestamp ts) throws RocksDBException {
- try (WriteOptions opts = new WriteOptions()) {
+ try (WriteOptions opts = new WriteOptions().setDisableWAL(true)) {
Review Comment:
Sure
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -239,20 +243,25 @@ public void start() {
}
private static List<ColumnFamilyDescriptor> cfDescriptors() {
- Options dataOptions = new Options().setCreateIfMissing(true)
+ Options sharedOptions = new Options()
Review Comment:
"baseOptions", thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org