You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2014/02/25 09:05:02 UTC

[2/6] git commit: Skip test on platforms it cannot run.

Skip test on platforms it cannot run.


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/6c0aad5a
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/6c0aad5a
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/6c0aad5a

Branch: refs/heads/master
Commit: 6c0aad5a9dc14d7c1c70486e7c66ccfc88bac7cb
Parents: c39570c
Author: Claus Ibsen <da...@apache.org>
Authored: Tue Feb 25 08:55:13 2014 +0100
Committer: Claus Ibsen <da...@apache.org>
Committed: Tue Feb 25 09:05:50 2014 +0100

----------------------------------------------------------------------
 .../xmlsecurity/ECDSASignatureTest.java         | 48 ++++++++++++--------
 1 file changed, 29 insertions(+), 19 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/6c0aad5a/components/camel-xmlsecurity/src/test/java/org/apache/camel/component/xmlsecurity/ECDSASignatureTest.java
----------------------------------------------------------------------
diff --git a/components/camel-xmlsecurity/src/test/java/org/apache/camel/component/xmlsecurity/ECDSASignatureTest.java b/components/camel-xmlsecurity/src/test/java/org/apache/camel/component/xmlsecurity/ECDSASignatureTest.java
index 03c86e9..80da3a2 100644
--- a/components/camel-xmlsecurity/src/test/java/org/apache/camel/component/xmlsecurity/ECDSASignatureTest.java
+++ b/components/camel-xmlsecurity/src/test/java/org/apache/camel/component/xmlsecurity/ECDSASignatureTest.java
@@ -49,24 +49,28 @@ public class ECDSASignatureTest extends CamelTestSupport {
     private static String payload = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
         + "<root xmlns=\"http://test/test\"><test>Test Message</test></root>";
     
-    private boolean ibmJDK;
+    private boolean canTest = true;
 
     public ECDSASignatureTest() throws Exception {
+        try {
+            // BouncyCastle is required for ECDSA support for JDK 1.6
+            if (isJava16() && Security.getProvider("BC") == null) {
+                Constructor<?> cons;
+                Class<?> c = Class.forName("org.bouncycastle.jce.provider.BouncyCastleProvider");
+                cons = c.getConstructor(new Class[] {});
+
+                Provider provider = (java.security.Provider)cons.newInstance();
+                Security.insertProviderAt(provider, 2);
+            }
 
-        // BouncyCastle is required for ECDSA support for JDK 1.6
-        if (isJava16()
-            && Security.getProvider("BC") == null) {
-            Constructor<?> cons = null;
-            Class<?> c = Class.forName("org.bouncycastle.jce.provider.BouncyCastleProvider");
-            cons = c.getConstructor(new Class[] {});
-            
-            Provider provider = (java.security.Provider)cons.newInstance();
-            Security.insertProviderAt(provider, 2);
-        }
-        
-        // This test fails with the IBM JDK
-        if (isJavaVendor("IBM")) {
-            ibmJDK = true;
+            // This test fails with the IBM JDK
+            if (isJavaVendor("IBM")) {
+                canTest = false;
+            }
+        } catch (Exception e) {
+            System.err.println("Cannot test due " + e.getMessage());
+            log.warn("Cannot test due " + e.getMessage(), e);
+            canTest = false;
         }
     }
 
@@ -75,7 +79,7 @@ public class ECDSASignatureTest extends CamelTestSupport {
         JndiRegistry registry = super.createRegistry();
 
         // This test fails with the IBM JDK
-        if (!ibmJDK) {
+        if (canTest) {
             registry.bind("accessor", getKeyAccessor());
             registry.bind("selector", KeySelector.singletonKeySelector(getCertificateFromKeyStore().getPublicKey()));
             registry.bind("uriDereferencer", getSameDocumentUriDereferencer());
@@ -86,7 +90,7 @@ public class ECDSASignatureTest extends CamelTestSupport {
 
     @Override
     protected RouteBuilder[] createRouteBuilders() throws Exception {
-        if (ibmJDK) {
+        if (!canTest) {
             return new RouteBuilder[] {};
         }
         
@@ -108,7 +112,7 @@ public class ECDSASignatureTest extends CamelTestSupport {
 
     @Test
     public void testECDSASHA1() throws Exception {
-        if (ibmJDK) {
+        if (!canTest) {
             return;
         }
         setupMock();
@@ -129,7 +133,13 @@ public class ECDSASignatureTest extends CamelTestSupport {
     @Before
     public void setUp() throws Exception {
         disableJMX();
-        super.setUp();
+        try {
+            super.setUp();
+        } catch (Exception e) {
+            System.err.println("Cannot test due " + e.getMessage());
+            log.warn("Cannot test due " + e.getMessage(), e);
+            canTest = false;
+        }
     }
 
     private static KeyStore loadKeystore() throws Exception {