[jira] [Commented] (FLINK-9573) Check for leadership with leader session id

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509681#comment-16509681 ] 

ASF GitHub Bot commented on FLINK-9573:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/6154

     [FLINK-9573] Extend LeaderElectionService#hasLeadership to take leader session id

    ## What is the purpose of the change
    
    The new `LeaderElectionService#hasLeadership` also takes the leader session id and verifies whether
    this is the correct leader session id associated with the leadership.
    
    ## Brief change log
    
    - Extend `LeaderElectionService#hasLeadership` to take a leader session id and check whether it identifies the current leader session
    - Adapt the calls to `LeaderElectionService#hasLeadership` to take the current leader session id
    
    ## Verifying this change
    
    - Added `LeaderElectionTest`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink extendLeaderElectionService

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6154
    
----
commit 54831c6a07dfcd5691fd732148a7c559514362ec
Author: Till Rohrmann <tr...@...>
Date:   2018-06-12T13:22:50Z

    [hotfix] Remove Scala dependency from ZooKeeperLeaderElectionTest

commit e50034088f4d85fe457e7015f162a6f86b1de9e7
Author: Till Rohrmann <tr...@...>
Date:   2018-06-12T12:24:59Z

    [FLINK-9573] Extend LeaderElectionService#hasLeadership to take leader session id
    
    The new LeaderElectionService#hasLeadership also takes the leader session id and verifies whether
    this is the correct leader session id associated with the leadership.

commit 104b46bd7848cd431afc564f6d3bb364a5257cf9
Author: Till Rohrmann <tr...@...>
Date:   2018-06-12T12:40:13Z

    [hotfix] Fix checkstyle violations in SingleLeaderElectionService

----


> Check for leadership with leader session id
> -------------------------------------------
>
>                 Key: FLINK-9573
>                 URL: https://issues.apache.org/jira/browse/FLINK-9573
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>
> In order to check whether a {{LeaderContender}} is still the leader, it is not sufficient to simply provide a {{LeaderElectionService#hasLeadership()}}. Instead, we should extend this method to also take the leader session id as a parameter to distinguish between different calls from the same leader contender with different leader session ids.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)