You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/11/11 01:17:11 UTC
[jira] [Commented] (AMBARI-13816) Save Cluster State Should Not Be
Automatically Skipped During Upgrade
[ https://issues.apache.org/jira/browse/AMBARI-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999652#comment-14999652 ]
Hudson commented on AMBARI-13816:
---------------------------------
SUCCESS: Integrated in Ambari-branch-2.1 #834 (See [https://builds.apache.org/job/Ambari-branch-2.1/834/])
AMBARI-13816 - Save Cluster State Should Not Be Automatically Skipped (jhurley: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=3765894ad954d565ce109cc13c1cdaaea7c7c21a])
* ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
* ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
* ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
* ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
* ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
* ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAOTest.java
* ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
* ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_skip_failures.xml
* ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java
* ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
* ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
* ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java
* ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java
* ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
* ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java
* ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
* ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
* ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
* ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
* ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
* ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
* ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
* ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
* ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
* ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql
* ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
* ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
* ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
> Save Cluster State Should Not Be Automatically Skipped During Upgrade
> ---------------------------------------------------------------------
>
> Key: AMBARI-13816
> URL: https://issues.apache.org/jira/browse/AMBARI-13816
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.1.3
> Reporter: Jonathan Hurley
> Assignee: Jonathan Hurley
> Priority: Blocker
> Fix For: 2.1.3
>
>
> The easiest solution here is to make a new group for the finalize action and then make that group not skippable. However, that might not be a desirable "feature" This step exists in a skippable group, which means it can be automatically skipped
> {code}
> <execute-stage title="Save Cluster State" service="" component="">
> <task xsi:type="server_action" class="org.apache.ambari.server.serveraction.upgrades.FinalizeUpgradeAction"/>
> </execute-stage>
> {code}
> But this task should never be auto skipped - I'd argue that it should never be skipped at all. Either abort the upgrade if this fails or downgrade or finalize later. However, it seems that the overall approach is to allow most upgrade items to be skipped.
> If we say that, "No, finalize _must_ also be skippable because we always want them to 'finish' the upgrade", then I think we'd need to do some work here to introduce the notion of a non-auto-skip property in the XML.
> {code}
> <group xsi:type="cluster" name="POST_CLUSTER" title="Finalize {{direction.text.proper}}">
> <skippable>true</skippable>
> <supports-auto-skip-failure>false</supports-auto-skip-failure>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)