You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rave.apache.org by Stanton Sievers <si...@gmail.com> on 2014/02/21 19:02:06 UTC

Review Request 18362: Toolbar action contributions' tooltips don't appear

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18362/
-----------------------------------------------------------

Review request for rave.


Bugs: RAVE-1093
    https://issues.apache.org/jira/browse/RAVE-1093


Repository: rave


Description
-------

Simply using the "title" attribute to show tooltips on toolbar actions

>From JIRA:
When a gadget contributes an action to its chrome's toolbar via the "gadget/toolbar" path, the action will render but the provided tooltip is not displayed.

The issue here is that the wrong attribute is being used to define the tooltip.  It is currently "tooltip", which is not a valid HTML attribute, when it should be "title".


Diffs
-----

  https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_ui.js 1570644 

Diff: https://reviews.apache.org/r/18362/diff/


Testing
-------

Tested in a custom portal.


Thanks,

Stanton Sievers