You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Rod Coffin (JIRA)" <ji...@codehaus.org> on 2005/08/08 14:59:57 UTC
[jira] Created: (MNG-710) Add ability to fork the maven-compiler-plugin
Add ability to fork the maven-compiler-plugin
---------------------------------------------
Key: MNG-710
URL: http://jira.codehaus.org/browse/MNG-710
Project: Maven 2
Type: Improvement
Components: maven-plugins
Reporter: Rod Coffin
Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_52094 ]
Brett Porter commented on MNG-710:
----------------------------------
Mark - yes. But what do you mean "will"?
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "jan gunnar gr?nnings?ter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51530 ]
jan gunnar grønningsæter commented on MNG-710:
----------------------------------------------
Hello.
Regarding the M2 "forking jdk" :
<fork>true</fork>
<basedir>c:/jdk1.3/bin</basedir>
Do I have wrong release (Maven 2.0)? I'm still stuck with this message
in my POM.xml (the Maven 1.1-beta-2 did it perfect in the project.properties...) :
BUILD ERROR
[11/21/05 16:40:13:092 CET] 76047604 SystemOut O [exec] [INFO] ----------------------------------------------------------------------------
[11/21/05 16:40:13:132 CET] 76047604 SystemOut O [exec] [INFO] Error configuring: org.apache.maven.plugins:maven-compiler-plugin. Reason: ERROR: Cannot override read-only parameter: basedir in goal: compiler:compile
[11/21/05 16:40:13:152 CET] 76047604 SystemOut O [exec] [INFO] ----------------------------------------------------------------------------
[11/21/05 16:40:13:152 CET] 76047604 SystemOut O [exec] [INFO] For more information, run Maven with the -e switch
Anyone have an example (I'm quite average on this theme...).
regards
Jan Gunnar
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44186 ]
Rod Coffin commented on MNG-710:
--------------------------------
So it sounds like we will need to add a comiler version parameter to the plexus compiler and add arguments based on this setting. I would be ok with this approach.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44137 ]
Rod Coffin commented on MNG-710:
--------------------------------
Good point about the plexus javac compiler being Sun javac specific. In that case I would be ok with adding a version flag and executing some logic in the external compile method to sort out version pecularities. Are you working on this or would you like me to take another pass at it? I wouldn't have any time available until tomorrow evening at the earliest.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45116 ]
Rod Coffin commented on MNG-710:
--------------------------------
Works great now, thanks Trygve!
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44179 ]
Rod Coffin commented on MNG-710:
--------------------------------
My bad with the style, I had it applied and must have messed up my settings. Would you like me to reapply the style and submit the diff? I'll also keep that in mind about the dependencies.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44185 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
If you are compiling this with a (internal or external) 1.4 compiler you will have to set the same flags by default (-source 1.3 -target 1.1). In what case is there a difference to the arguments that you need to pass to the compiler when it's external or internal? I don't mind making the Plexus compiler fully aware of the options that can be passed to the compiler, we are going this to make it easier to use Maven. You still have the "compiler arguments" property that you can set if you need additional arguments.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Brett Porter updated MNG-710:
-----------------------------
Fix Version: 2.0-beta-1
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44140 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
Plexus parts committed.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44181 ]
Rod Coffin commented on MNG-710:
--------------------------------
I think checking the fork flag would work if you specify source and target in your plugin configuration. Basically if forking those flags wouldn't be set by default but could be specified explicitly. How does this compare in your opinion to passing a compiler version parameter? I like putting the onus on the developer using an out of process compiler to specify the appropriate arguments. That way we don't have to anticipate all these cases in the plexus compiler.
I definitely agree about making all this testable. It is a little challenging to unit test invoking a compiler. But certainly we can define and test the argument reqs.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44177 ]
Rod Coffin commented on MNG-710:
--------------------------------
I've tried out these changes and the only problem I see at this point is that the source argument is always being passed, even if forking to a jdk 1.3 compiler. I'm attaching another patch to illustrate one potential solution to this.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45086 ]
Rod Coffin commented on MNG-710:
--------------------------------
I just tried compiling with a forked JDK 1.3 compiler and it seems that the source parameter is still being passed to the compiler. I think this is because the compilerVersion parameter is not being passed from the Maven compiler plugin to the plexus compiler. My previous maven-compiler-plugin.diff3.txt attachment provides one possible solution for this.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---------------------------
Attachment: plexus-compiler-javac.diff2.txt
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51557 ]
Brett Porter commented on MNG-710:
----------------------------------
jan: set executable not basedir
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Mark Proctor (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_52044 ]
Mark Proctor commented on MNG-710:
----------------------------------
Will this allow different java versions to be specified on a per module basis, in a multi module build?
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44178 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
I'll look into this soon, just a few comments:
1) Do not change how the code looks, at least not when you're not using the existing style
2) Do not add dependencies that's not required, and always make sure you comment why you add a dependency to the project.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45100 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
Hm, woops, must've missed that part. I'll fix that asap.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "jan gunnar gr?nnings?ter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51744 ]
jan gunnar grønningsæter commented on MNG-710:
----------------------------------------------
Thanks again, Brett ! - I'll do that.
Jan G.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44136 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
Ok, I see your argument but this implementation is Sun javac specific because all the compilers have their own output format. I would like to share as much as possible of the code between the internal and external versions and hopefully that'll be possible. I'd rather add a "compiler version" argument than requiring the user to pass all the arguments by hand.
I've removed the working directory from the Mojo but kept it in the Plexus compiler.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44134 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
Is this the only different option? If so it's best to build that into the compiler instead of having to pass in all the arguments all over again.
Also, why was the working directory argument added?
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---------------------------
Attachment: maven-compiler-plugin.diff.txt
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44139 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
I've collapsed the generation of the arguments now and will try it out on with the different compilers I have here.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---------------------------
Attachment: maven-compiler-plugin.diff3.txt
plexus-compiler-javac.diff3.txt
plexus-compiler-api.diff3.txt
I've added unit tests for building an argument string for several versions of the javac compiler. I also enhanced the plexus compiler and the maven compiler plugin to correctly handle jdk 1.3 arguments by passing a compilerVersion parameter in the CompilerConfiguration object.
I realized why my source weren't properly formatted last time. I have the Maven format installed instead of the plexus one. Where can I get the plexus format template for Eclipse? In the meantime I just tried to do the best job I could manually adhering to the code style I found in the rest of the file.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44133 ]
Rod Coffin commented on MNG-710:
--------------------------------
Valid compiler arguements differ based on the version of the compiler used. For example, we don't want to pass the 'source' argument to a 1.3 compiler or the compiler will complain. If we want to preserve the behavior of defaulting source to '1.3' if it is not specified then we should only do this for inprocess compilation.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---------------------------
Attachment: plexus-compiler-api.diff.txt
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "jan gunnar gr?nnings?ter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51567 ]
jan gunnar grønningsæter commented on MNG-710:
----------------------------------------------
Brett - Well, I did it right away.
- Just to say *it worked*, really do appreciate that, Sir!
Jan G
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44129 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
Why don't you pass the same arguments list to both the internal and external compiler?
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44190 ]
Rod Coffin commented on MNG-710:
--------------------------------
I can write some test cases for this but won't have the time until tomorrow night. When I get the chance I'll create a few and upload them as a diff to this issue. I'll particularly make sure to get the JDK 1.3 arguments expressed in a test case.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44180 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
No, no problem, I'll fix it. It's not a big deal, it just makes it harder to see what you've really changed.
Anyway, from what I can tell this won't work with a jdk1.4+ external compiler. I think we need to add a "compiler version" parameter here so the compiler component can know how and when to specify the different -source and -target parameters. I've made the methods for building the argument lists public and static to make them easier to test so I'd like you to make some tests for this aswell. Just makes it ieasier for me and the next guy that has to maintain the component to understand the requirements.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45107 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
This should have been fixed now.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "jan gunnar gr?nnings?ter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51562 ]
jan gunnar grønningsæter commented on MNG-710:
----------------------------------------------
Thanks for your quick answer, Brett !
Reports back first thing in the morning.
Jan G
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "jan gunnar gr?nnings?ter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51642 ]
jan gunnar grønningsæter commented on MNG-710:
----------------------------------------------
Hello again ! - Seems I'm in serious trouble.
This is the successful part ->
[INFO] Scanning for projects...
[INFO] ----------------------------------------------------------------------------
[INFO] Building FellesServerJava-jdk1.3
[INFO] task-segment: [clean, install]
[INFO] ----------------------------------------------------------------------------
[INFO] [clean:clean]
[INFO] Deleting directory C:\MavenRoot\Kamel_utv\FellesServer\FellesServerJava\target
[INFO] [resources:resources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:compile]
Compiling 56 source files to C:\MavenRoot\Kamel_utv\FellesServer\FellesServerJava\target\classes
[INFO] [resources:testResources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:testCompile]
[INFO] No sources to compile
[INFO] [surefire:test]
[INFO] No tests to run.
[INFO] [jar:jar]
[INFO] Building jar: C:\MavenRoot\Kamel_utv\FellesServer\FellesServerJava\target\FellesServerJava-jdk1.3.jar
[INFO] [install:install]
[INFO] Installing C:\MavenRoot\Kamel_utv\FellesServer\FellesServerJava\target\FellesServerJava-jdk1.3.jar to C:\Documents and Settings\g007774\.m2\repository\Kamel_utv\FellesServerJava\jdk1.3\FellesServerJava-jdk1.3.jar
[INFO] ----------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ----------------------------------------------------------------------------
[INFO] Total time: 3 seconds
[INFO] Finished at: Tue Nov 22 13:29:59 CET 2005
[INFO] Final Memory: 3M/7M
[INFO] ----------------------------------------------------------------------------
The generated .pom file - first part(sent to local repo due to install - so far, so good)
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>Kamel_utv</groupId>
<artifactId>FellesServerJava</artifactId>
<name>FellesServerJava-jdk1.3</name>
<version>jdk1.3</version>
<url>http://mstc1040/mavensitereports</url>
<build>
<plugins>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<fork>true</fork>
<compilerVersion>1.3</compilerVersion>
<executable>C:/jdk1.3.1/bin/javac.exe</executable>
<target>1.3</target>
</configuration>
</plugin>
</plugins>
</build>
<repositories>
<repository>
<id>tjenestelag</id>
<url>file://c:/prosjekter/tjenestelag-repository/local-dependencies</url>
</repository>
<repository>
<id>ibiblio-plexus</id>
<url>http://www.ibiblio.org/maven2/plexus</url>
</repository>
</repositories>
<dependencies>
<dependency>
<groupId>com.tivoli</groupId>
<artifactId>pd</artifactId>
<version>jdk1.3</version>
</dependency>
....
....
....
....
</dependencies>
....
</project>
-------------------------------------------------------------------------------------------------------------------------------------------------------------
Here comes the point of disaster (once I put in the security package) - no reasonable message?!
56 files' getting SUCCESSFUL - the 57th's "plugging the party" (the LDAPServer.java, listed below) ...
[INFO] Scanning for projects...
[INFO] ----------------------------------------------------------------------------
[INFO] Building FellesServerJava-jdk1.3
[INFO] task-segment: [clean, install]
[INFO] ----------------------------------------------------------------------------
[INFO] [clean:clean]
[INFO] Deleting directory C:\MavenRoot\Kamel_utv\FellesServer\FellesServerJava\target
[INFO] [resources:resources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:compile]
Compiling 57 source files to C:\MavenRoot\Kamel_utv\FellesServer\FellesServerJava\target\classes
[INFO] ----------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ----------------------------------------------------------------------------
[INFO] Compilation failure
Failure executing javac, but could not parse the error:
[INFO] ----------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ----------------------------------------------------------------------------
[INFO] Total time: 2 seconds
[INFO] Finished at: Tue Nov 22 13:37:48 CET 2005
[INFO] Final Memory: 3M/7M
[INFO] ----------------------------------------------------------------------------
This java-file (and package) DO NOT GET ACCEPTED (no reasonable message)
- Same POM all the way - albeit I'm not able to get this -jdk1.3 artifact generated.
It's a whole bunch of dependencies - just to mention. Don't have any trouble what-
soever when executing outside forking mode.
->
------Start of java file--------------
package no.gnf.ekomp.security;
/**
* This is a simple wrapper class for the name of an LDAP server and its priority.
* The class implements java.util.Comparable so the a list of instances can
* be sorted using the Collections Framework's sorting mechanisms.
* * <p>
* <b>Author </b>Anders Lund<br>
* <b>Date </b>19.09.2001<br>
* <b>Copyright </b>(C) Copyright Gjensidige NOR Forsikring 2001 - All rights Reserved<br>
* <p>
**/
public class LDAPServer implements Comparable {
/** The LDAP server's priorority */
private Integer priority;
/** The DNS name of the LDAP server */
private String server;
/**
* Constructs an instance of this class
**/
public LDAPServer( Integer pri, String serv ) {
priority = pri;
server = serv;
}
/**
* This method compares an instance of this class with another
* instance (of this class) based on the value of the server
* priority. See the description of the java.util.Comparable
* interface for a more detailed description of how this method
* works. See also the compareTo method of the java.lang.Integer
* class
**/
public int compareTo(Object o) {
LDAPServer other = (LDAPServer)o;
return priority.compareTo(other.priority);
}
/**
* Returns the server name
**/
public String getServer() {
return server;
}
/**
* Returns a String representation of an instance of
* this class.
**/
public String toString() {
return "[" + priority + "," + server + "]";
}
}
regards
Jan G
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_51704 ]
Brett Porter commented on MNG-710:
----------------------------------
Jan, please send your information to users@maven.apache.org - we can't really answer questions effectively in JIRA.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44188 ]
Trygve Laugstol commented on MNG-710:
-------------------------------------
Yeah, I think that would make most sense. We really need some test cases for this now.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Trygve Laugstol closed MNG-710:
-------------------------------
Resolution: Fixed
Fixed. Rod: can you please try it out?
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Fix For: 2.0-beta-1
> Attachments: maven-compiler-plugin.diff.txt, maven-compiler-plugin.diff3.txt, plexus-compiler-api.diff.txt, plexus-compiler-api.diff3.txt, plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt, plexus-compiler-javac.diff3.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---------------------------
Attachment: plexus-compiler-javac.diff.txt
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-710) Add ability to fork the maven-compiler-plugin
Posted by "Rod Coffin (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44135 ]
Rod Coffin commented on MNG-710:
--------------------------------
The problem is that users of this plugin can specify any arbitrary java compiler. So the compiler type (IBM, Sun, etc.) and version could all vary. I don't know if it would be wise to attempt to anticipate which arguments might be valid and which might not. That is why I separated out a core set of common arguments which are just the minimum set of arguments (output directory, classpath, and source path). Is your concern passing the args from the compile method to the compileOutOfProcess and compileInProcess methods? If so, how about having each compilation method create its own arguments using the addXXXArguments method?
Working directory was added to allow users to define which directory to run the compiler from. In hindsight it could probably be removed.
> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
> Key: MNG-710
> URL: http://jira.codehaus.org/browse/MNG-710
> Project: Maven 2
> Type: Improvement
> Components: maven-plugins
> Reporter: Rod Coffin
> Assignee: Trygve Laugstol
> Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, plexus-compiler-javac.diff.txt
>
>
> Add the ability to fork the maven-compiler-plugin. This would allow projects to be compiled with a JDK other than the one used to run Maven from.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org