You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/07 19:53:40 UTC

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #830: GEODE-8891: Make static regex a Meyers Singleton in ThinClientRegion

pivotal-jbarrett commented on a change in pull request #830:
URL: https://github.com/apache/geode-native/pull/830#discussion_r665663993



##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -49,8 +49,14 @@ namespace apache {
 namespace geode {
 namespace client {
 
-static const std::regex PREDICATE_IS_FULL_QUERY_REGEX(
-    "^\\s*(?:select|import)\\b", std::regex::icase);
+class IsFullQueryRegex {

Review comment:
       I guess I would have just don it within the `ThinClientRegion` class and made the method `private` since there is no need for it to be public (well maybe for tests but there are none).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org