You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/10 23:28:11 UTC

[GitHub] [airflow] simis2626 opened a new pull request #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

simis2626 opened a new pull request #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395
 
 
   …dOperator
   
   Changes allow user to specify priority_class_name within KubernetesPodOperator
   which sets the Pod.spec value to influence scheduling and preemption behaviour
   of workloads generated by Airflow.
   
   pre-commit hook issue with BREEZE.rst adding whitespace - Can't push without committing whitespace change.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] simis2626 commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

simis2626 commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-586034102
 
 
   Thank you @potiuk appreciate the diagnosis! 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-585611569
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=h1) Report
   > Merging [#7395](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/58c3542ed25061320ce61dbe0adf451a44c738dd?src=pr&el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7395/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7395     +/-   ##
   =========================================
   - Coverage   86.53%   86.43%   -0.1%     
   =========================================
     Files         874      874             
     Lines       40868    40870      +2     
   =========================================
   - Hits        35365    35326     -39     
   - Misses       5503     5544     +41
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `94.94% <100%> (+0.05%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `96.51% <100%> (+0.01%)` | :arrow_up: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0%> (-64.16%)` | :arrow_down: |
   | [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
   | [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
   | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `90% <0%> (-6.67%)` | :arrow_down: |
   | [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-0.87%)` | :arrow_down: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.93% <0%> (-0.2%)` | :arrow_down: |
   | [airflow/www/api/experimental/endpoints.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBpL2V4cGVyaW1lbnRhbC9lbmRwb2ludHMucHk=) | `89.81% <0%> (ø)` | :arrow_up: |
   | ... and [5 more](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=footer). Last update [58c3542...51119ff](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

kaxil commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-590137575
 
 
   @simis2626 good work
   
   @dimberman I think this was safe to merge but if you think otherwise let me know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-584409286

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

potiuk commented on a change in pull request #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#discussion_r378697882
 
 

 ##########
 File path: BREEZE.rst
 ##########
 @@ -670,7 +670,7 @@ This is the current syntax for  `./breeze <./breeze>`_:
           Integration to start during tests - it determines which integrations are started for integration
           tests. There can be more than one integration started, or all to start all integrations.
           Selected integrations are not saved for future execution.
-          One of [ cassandra kerberos mongo openldap rabbitmq redis all ]. Default:
+          One of [ cassandra kerberos mongo openldap rabbitmq redis all ]. Default: 
 
 Review comment:
   ```suggestion
             One of [ cassandra kerberos mongo openldap rabbitmq redis all ]. Default:
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-585611569
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=h1) Report
   > Merging [#7395](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/58c3542ed25061320ce61dbe0adf451a44c738dd?src=pr&el=desc) will **increase** coverage by `0.09%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7395/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7395      +/-   ##
   ==========================================
   + Coverage   86.53%   86.63%   +0.09%     
   ==========================================
     Files         874      874              
     Lines       40868    40870       +2     
   ==========================================
   + Hits        35365    35406      +41     
   + Misses       5503     5464      -39
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `94.94% <100%> (+0.05%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `96.51% <100%> (+0.01%)` | :arrow_up: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.93% <0%> (-0.2%)` | :arrow_down: |
   | [airflow/www/api/experimental/endpoints.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBpL2V4cGVyaW1lbnRhbC9lbmRwb2ludHMucHk=) | `89.81% <0%> (ø)` | :arrow_up: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.34% <0%> (+0.43%)` | :arrow_up: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
   | [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `94.36% <0%> (+16.9%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `85.29% <0%> (+32.35%)` | :arrow_up: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `100% <0%> (+50%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=footer). Last update [58c3542...51119ff](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] simis2626 commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

simis2626 commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-588032431
 
 
   Hi @dimberman 
   Appreciate your recent return to this work, just pinging you incase it's slipped by.
   Thanks in advance, appreciate your support & time.
   Simon

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] simis2626 commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

simis2626 commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-585475137
 
 
   ![Screenshot from 2020-02-13 10-41-22](https://user-images.githubusercontent.com/18462964/74387785-a66f9400-4e4d-11ea-8b01-327f1f1218aa.png)
   Running command as given in failed travis-ci job doesn't give any error.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-585597844
 
 
   The new build should work and once I merge  the #7388  it should not occur any more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-585596511
 
 
   It's an interesting one. Seems that it can be some local setup of your environment - bash output is apparently different if you have empty variable. I actually noticed this empty default yesterday and I have a fix for that in #7388 but I think what will help on your case will be to remove the Default that is empty..I will make a suggestion in a moment 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-585611569
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=h1) Report
   > Merging [#7395](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/58c3542ed25061320ce61dbe0adf451a44c738dd?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7395/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7395      +/-   ##
   ==========================================
   - Coverage   86.53%   86.51%   -0.03%     
   ==========================================
     Files         874      874              
     Lines       40868    40922      +54     
   ==========================================
   + Hits        35365    35402      +37     
   - Misses       5503     5520      +17
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `94.94% <100%> (+0.05%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `96.51% <100%> (+0.01%)` | :arrow_up: |
   | [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `85.29% <0%> (-5.19%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.43% <0%> (-1.16%)` | :arrow_down: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.93% <0%> (-0.2%)` | :arrow_down: |
   | [airflow/www/api/experimental/endpoints.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBpL2V4cGVyaW1lbnRhbC9lbmRwb2ludHMucHk=) | `89.81% <0%> (ø)` | :arrow_up: |
   | [...low/providers/google/cloud/operators/sql\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9zcWxfdG9fZ2NzLnB5) | `92.07% <0%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=footer). Last update [58c3542...a6dea34](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-585611569
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=h1) Report
   > Merging [#7395](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/58c3542ed25061320ce61dbe0adf451a44c738dd?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7395/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7395      +/-   ##
   ==========================================
   - Coverage   86.53%   86.51%   -0.03%     
   ==========================================
     Files         874      874              
     Lines       40868    40922      +54     
   ==========================================
   + Hits        35365    35402      +37     
   - Misses       5503     5520      +17
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `94.94% <100%> (+0.05%)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `96.51% <100%> (+0.01%)` | :arrow_up: |
   | [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `85.29% <0%> (-5.19%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.43% <0%> (-1.16%)` | :arrow_down: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.93% <0%> (-0.2%)` | :arrow_down: |
   | [airflow/www/api/experimental/endpoints.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBpL2V4cGVyaW1lbnRhbC9lbmRwb2ludHMucHk=) | `89.81% <0%> (ø)` | :arrow_up: |
   | [...low/providers/google/cloud/operators/sql\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7395/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9zcWxfdG9fZ2NzLnB5) | `92.07% <0%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=footer). Last update [58c3542...a6dea34](https://codecov.io/gh/apache/airflow/pull/7395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

kaxil merged pull request #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on issue #7395: [AIRFLOW-5629] Implement K8s priorityClassName in KubernetesPo…
URL: https://github.com/apache/airflow/pull/7395#issuecomment-590137320
 
 
   Awesome work, congrats on your first merged pull request!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services