[GitHub] [flink] zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #10637: [FLINK-15319][e2e] flink-end-to-end-tests-common-kafka fails due to t…
URL: https://github.com/apache/flink/pull/10637#discussion_r362814545
 
 

 ##########
 File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
 ##########
 @@ -91,6 +91,30 @@ public void afterTestSuccess() {
 
 	abstract boolean matchesCachedFile(Matcher matcher, String url);
 
+	private long getDownloadTimeoutMillis() {
+		String downloadTimeoutProp = System.getProperty("downloadTimeoutMillis");
+		long downloadTimeout = 5 * 60 * 1000; // default 5min.
+		if (downloadTimeoutProp != null && downloadTimeoutProp.length() > 0) {
+			downloadTimeout = Long.parseLong(downloadTimeoutProp);
+			if (downloadTimeout <= 0) {
+				throw new IllegalArgumentException("Illegal property setting: -DdownloadTimeoutMillis=" + downloadTimeoutProp);
+			}
+		}
+		return downloadTimeout;
+	}
+
+	private int getDownloadMaxRetries() {
+		String downloadMaxRetriesProp = System.getProperty("downloadMaxRetries");
 
 Review comment:
   Let's refactor this to be a `ParameterProperty`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services