You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Mladen Turk (JIRA)" <ji...@apache.org> on 2010/05/21 06:11:16 UTC
[jira] Created: (TS-366) Reorganize the configure config.h
Reorganize the configure config.h
---------------------------------
Key: TS-366
URL: https://issues.apache.org/jira/browse/TS-366
Project: Traffic Server
Issue Type: Improvement
Components: Build
Reporter: Mladen Turk
Assignee: Mladen Turk
Fix For: 2.1.0
We are currently generating config,h using autoconf
Instead this use the template inktomi++/ink_config.h.in and rewrite it instead using config.in
This will allow to have all defines allways defined as either 1 or 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-366) Reorganize the configure config.h
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869860#action_12869860 ]
Leif Hedstrom commented on TS-366:
----------------------------------
You should talk to John about this, he had some reasons why he did it the way it was done.
> Reorganize the configure config.h
> ---------------------------------
>
> Key: TS-366
> URL: https://issues.apache.org/jira/browse/TS-366
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
> Reporter: Mladen Turk
> Assignee: Mladen Turk
> Fix For: 2.1.0
>
>
> We are currently generating config,h using autoconf
> Instead this use the template inktomi++/ink_config.h.in and rewrite it instead using config.in
> This will allow to have all defines allways defined as either 1 or 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-366) Reorganize the configure config.h
Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869893#action_12869893 ]
Mladen Turk commented on TS-366:
--------------------------------
Will do.
The idea is to split some of the defines from autoconf.h to ink_config.in
That way some defines will be always there either defined as 1 or 0
Typical usage would be for os includes so we can use
#if HAVE_PORT_T
#include <port.h>
#endif
instead current
#ifdef HAVE_PORT_H
#include <port.h>
#endif
This will also allow to name space protect some of the defines
Best would be to have them all prefixed with ATS_
so that eventual custom plugin includes doesn;t collide with ours.
Finally, anything that really needs to be checked via #ifdef should be in CPPFLAGS
> Reorganize the configure config.h
> ---------------------------------
>
> Key: TS-366
> URL: https://issues.apache.org/jira/browse/TS-366
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
> Reporter: Mladen Turk
> Assignee: Mladen Turk
> Fix For: 2.1.0
>
>
> We are currently generating config,h using autoconf
> Instead this use the template inktomi++/ink_config.h.in and rewrite it instead using config.in
> This will allow to have all defines allways defined as either 1 or 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TS-366) Reorganize the configure config.h
Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mladen Turk closed TS-366.
--------------------------
Resolution: Fixed
Using inktomi++/ink_config.h.in as a configure template for enabled features
> Reorganize the configure config.h
> ---------------------------------
>
> Key: TS-366
> URL: https://issues.apache.org/jira/browse/TS-366
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
> Reporter: Mladen Turk
> Assignee: Mladen Turk
> Fix For: 2.1.1
>
> Attachments: rename-host-os.sh
>
>
> We are currently generating config,h using autoconf
> Instead this use the template inktomi++/ink_config.h.in and rewrite it instead using config.in
> This will allow to have all defines allways defined as either 1 or 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-366) Reorganize the configure config.h
Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mladen Turk updated TS-366:
---------------------------
Attachment: rename-host-os.sh
Script for renaming HOST_OS == foo to defined(foo)
> Reorganize the configure config.h
> ---------------------------------
>
> Key: TS-366
> URL: https://issues.apache.org/jira/browse/TS-366
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
> Reporter: Mladen Turk
> Assignee: Mladen Turk
> Fix For: 2.1.0
>
> Attachments: rename-host-os.sh
>
>
> We are currently generating config,h using autoconf
> Instead this use the template inktomi++/ink_config.h.in and rewrite it instead using config.in
> This will allow to have all defines allways defined as either 1 or 0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.