You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/08/02 21:53:56 UTC
[GitHub] [pinot] elonazoulay opened a new issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
elonazoulay opened a new issue #7242:
URL: https://github.com/apache/pinot/issues/7242
Can the limit for broker requests be changed to long type instead of integer type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] elonazoulay commented on issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
Posted by GitBox <gi...@apache.org>.
elonazoulay commented on issue #7242:
URL: https://github.com/apache/pinot/issues/7242#issuecomment-892790558
Mostly for the Trino connector - if a limit is pushed down (which is of long type) that exceeds Integer.MAX_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] elonazoulay commented on issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
Posted by GitBox <gi...@apache.org>.
elonazoulay commented on issue #7242:
URL: https://github.com/apache/pinot/issues/7242#issuecomment-892790558
Mostly for the Trino connector - if a limit is pushed down (which is of long type) that exceeds Integer.MAX_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] elonazoulay commented on issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
Posted by GitBox <gi...@apache.org>.
elonazoulay commented on issue #7242:
URL: https://github.com/apache/pinot/issues/7242#issuecomment-894604019
What about the grpc endpoint? Would it be possible to have long limit in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] elonazoulay commented on issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
Posted by GitBox <gi...@apache.org>.
elonazoulay commented on issue #7242:
URL: https://github.com/apache/pinot/issues/7242#issuecomment-894603971
Thanks, sounds good! For the connector there is a new pr which adds an explicit limit (integer) to broker queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7242:
URL: https://github.com/apache/pinot/issues/7242#issuecomment-893869682
@elonazoulay We don't want to allow such large limit because the query result is held in memory in Pinot. For now a solution would be to rewrite the limit to Integer.MAX_VALUE if we detect a larger limit in Trino connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] elonazoulay commented on issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
Posted by GitBox <gi...@apache.org>.
elonazoulay commented on issue #7242:
URL: https://github.com/apache/pinot/issues/7242#issuecomment-894604049
Could be used to export and reimport (or copy) a pinot table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7242:
URL: https://github.com/apache/pinot/issues/7242#issuecomment-895467442
Currently the `PinotQuery` (parsed pinot query) has `limit` as an `int` field, so it is hard to add it. One possible workaround would be put the long limit as a query option, but that is quite hacky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7242: Pinot broker request has a limit of Integer.MAX_VALUE rows
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7242:
URL: https://github.com/apache/pinot/issues/7242#issuecomment-891431505
Currently `LIMIT` is modeled as an int in the thrift object, and changing it to long involves protocol change.
Can you please elaborate the use case where you want to put super large limit? We might want to allow unlimited (no limit) in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org