You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by David Salter <we...@gmail.com> on 2019/06/27 14:43:08 UTC

New Issue and PR

Hi,

I’ve just created a new issue and PR to fix some typos on the MP Config example readme.

Could someone take a look and see of these are ok?

https://issues.apache.org/jira/browse/TOMEE-2552 <https://issues.apache.org/jira/browse/TOMEE-2552>
https://github.com/apache/tomee/pull/497 <https://github.com/apache/tomee/pull/497>

Thanks,

David.

Re: New Issue and PR

Posted by Jonathan Gallimore <jo...@gmail.com>.

Done, thank you both!

On Thu, Jun 27, 2019 at 3:54 PM David Salter <we...@gmail.com>
wrote:

> Thanks    Daniel :)
>
> > On 27 Jun 2019, at 15:48, Daniel Dias Dos Santos <
> daniel.dias.analistati@gmail.com> wrote:
> >
> > Hi David,
> >
> > Thanks for the contribution,
> >
> > I reviewed your PR .
> >
> > Committers, can you please move forward this contribution.
> > --
> >
> > *Daniel Dias dos Santos*
> > Java Developer
> > SouJava & JCP Member
> > GitHub: https://github.com/Daniel-Dos
> > Linkedin: www.linkedin.com/in/danieldiasjava
> > Twitter: http://twitter.com/danieldiasjava
> >
> >
> > Em qui, 27 de jun de 2019 às 11:43, David Salter <
> wedevelopinjava@gmail.com>
> > escreveu:
> >
> >> Hi,
> >>
> >> I’ve just created a new issue and PR to fix some typos on the MP Config
> >> example readme.
> >>
> >> Could someone take a look and see of these are ok?
> >>
> >> https://issues.apache.org/jira/browse/TOMEE-2552 <
> >> https://issues.apache.org/jira/browse/TOMEE-2552>
> >> https://github.com/apache/tomee/pull/497 <
> >> https://github.com/apache/tomee/pull/497>
> >>
> >> Thanks,
> >>
> >> David.
> >>
> >>
>
>

Re: New Issue and PR

Posted by David Salter <we...@gmail.com>.

Thanks Daniel :)

> On 27 Jun 2019, at 15:48, Daniel Dias Dos Santos <da...@gmail.com> wrote:
> 
> Hi David,
> 
> Thanks for the contribution,
> 
> I reviewed your PR .
> 
> Committers, can you please move forward this contribution.
> --
> 
> *Daniel Dias dos Santos*
> Java Developer
> SouJava & JCP Member
> GitHub: https://github.com/Daniel-Dos
> Linkedin: www.linkedin.com/in/danieldiasjava
> Twitter: http://twitter.com/danieldiasjava
> 
> 
> Em qui, 27 de jun de 2019 às 11:43, David Salter <we...@gmail.com>
> escreveu:
> 
>> Hi,
>> 
>> I’ve just created a new issue and PR to fix some typos on the MP Config
>> example readme.
>> 
>> Could someone take a look and see of these are ok?
>> 
>> https://issues.apache.org/jira/browse/TOMEE-2552 <
>> https://issues.apache.org/jira/browse/TOMEE-2552>
>> https://github.com/apache/tomee/pull/497 <
>> https://github.com/apache/tomee/pull/497>
>> 
>> Thanks,
>> 
>> David.
>> 
>>

Re: New Issue and PR

Posted by Daniel Dias Dos Santos <da...@gmail.com>.

Hi David,

Thanks for the contribution,

I reviewed your PR .

Committers, can you please move forward this contribution.
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


Em qui, 27 de jun de 2019 às 11:43, David Salter <we...@gmail.com>
escreveu:

> Hi,
>
> I’ve just created a new issue and PR to fix some typos on the MP Config
> example readme.
>
> Could someone take a look and see of these are ok?
>
> https://issues.apache.org/jira/browse/TOMEE-2552 <
> https://issues.apache.org/jira/browse/TOMEE-2552>
> https://github.com/apache/tomee/pull/497 <
> https://github.com/apache/tomee/pull/497>
>
> Thanks,
>
> David.
>
>