You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zmuxuny (via GitHub)" <gi...@apache.org> on 2026/10/14 09:54:29 UTC
[PR] fix(web): clear topology snapshots when instance scope changes [rocketmq-dashboard]
zmuxuny opened a new pull request, #6653:
URL: https://github.com/apache/rocketmq-dashboard/pull/6653
### Which Issue(s) This PR Fixes
Fixes #6628.
### Brief Description
Clear completed Broker/NameServer/Proxy snapshots when the selected instance scope changes, preventing old-instance rows and CSV exports while the new instance is loading. Preserve same-instance refresh and existing request guards.
Credit to yuluo-yx's earlier report #2151 and closed, unmerged proposals #2156/#2201. The pending-scope interval remains reproducible after the load-failure work in #2899/#2904/#2893. This does not replace #5194's generation guard or #5645's polling-error work.
### Verification
Base: rocketmq-studio@779b8c0e7aed2396d3cc72743dcd544ea48e9ae6.
The following validation was completed on October 13, 2026 against the prepared source. The fork head and tree were rechecked on October 14; these tests are not claimed as a fresh rerun.
26 focused tests passed; an independent 10-test rerun passed. A separate compatibility check with #6348 passed 27 tests. Full frontend run: 1,612 tests in 159 files passed. Real component regressions cover all three topology tabs, disabled export during the scope transition and completed-request controls.
TypeScript/production build and artifact-license checks passed. Lint reported zero errors and ten existing warnings. Local tests used Node 24, while CI uses Node 20. Browser visual QA and a live cluster are not claimed.
Independent source/test review completed. AI assistance was used for implementation and regression authoring. Controlled fixtures were used; no live production incident, deployment or broker mutation is claimed. Upstream CI for this new PR remains to be verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): clear topology snapshots when instance scope changes [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #6653: fix(web): clear topology snapshots when instance scope changes
URL: https://github.com/apache/rocketmq-dashboard/pull/6653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): clear topology snapshots when instance scope changes [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #6653:
URL: https://github.com/apache/rocketmq-dashboard/pull/6653#issuecomment-6189377079
Consolidated into #6367 and merged into `rocketmq-studio` as [`0e73d2890`](https://github.com/apache/rocketmq-dashboard/commit/0e73d2890b36cc5c9401404c7bbb1aba27d3c84a). Your commit went in with its original authorship, so nothing is lost by closing this PR.
**What landed from this PR:** clear topology snapshots when the instance scope changes.
Nine frontend fixes by the same author (#6367 #6369 #6373 #6375 #6376 #6379 #6380 #6382 #6653) touched an overlapping set of files — `MetricsExplorer.test.tsx` alone was appended to by two of them — so they were reviewed as one unit and merged as one commit instead of nine trunk commits landing hours apart. Verification on the merged branch: 159 test files / 1666 tests green, `prettier --check` clean, `eslint` 0 errors (2 pre-existing warnings), and every added line of all nine source PRs confirmed present.
`Fixes #6628` does not auto-close because the merge target `rocketmq-studio` is not the default branch, so #6628 is being closed separately with a reference to the merged commit.
Thanks for the fix, and sorry for the extra hop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org