[GitHub] [qpid-cpp] chrisrichardson77 commented on pull request #25: QPID-8516 Fix use of python2 in CMakeFiles excerpts

[GitBox <gi...@apache.org>]

chrisrichardson77 commented on pull request #25:
URL: https://github.com/apache/qpid-cpp/pull/25#issuecomment-816539144


   > I am uncertain about what we're trying to achieve there. For example, the Python binding library will need a lot more work to make it usable with Python 3... Are you simply trying to make the compilation work, with the intention of using the C++ parts?
   > 
   > I was wanting to compile the C++ client before, and I succeeded by configuring the project so that it does not build anything else. My build config is the following. It gets transformed into `cmake -D` options https://github.com/rh-messaging/cli-cpp/blob/master/BUILD.bazel#L62-L80
   > 
   > LGTM, I guess there is no harm in adding parens around `print` argument. It's a noop in Python 2.
   
   Fair point about the python binding, I'm not sure what will happen after the configure phase but I was thinking that could be part of a larger piece of work.
   The managementgen change seems to be key though, since you updated it to python3 in QPID-8413 so I'm assuming the intention is that it should build on a python3-only system.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org