[jira] [Commented] (OAK-4358) Stale cluster ids can potentially lead to lots of previous docs traversal in NodeDocument.getNewestRevision

["Vikas Saurabh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309390#comment-15309390 ] 

Vikas Saurabh commented on OAK-4358:
------------------------------------

[~mreutegg], lgtm. I'd work a bit to add some tests for getChanges() too.

> Stale cluster ids can potentially lead to lots of previous docs traversal in NodeDocument.getNewestRevision
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-4358
>                 URL: https://issues.apache.org/jira/browse/OAK-4358
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>    Affects Versions: 1.4.0
>            Reporter: Vikas Saurabh
>            Assignee: Marcel Reutegger
>              Labels: candidate_oak_1_4
>             Fix For: 1.5.3
>
>
> When some (actual test case and conditions still being investigated) of the following conditions are met:
> * There are property value changes from different cluster id
> * There are very old and stale cluster id (probably older incarnations of current node itself)
> * A parallel background split removes all _commitRoot, _revision entries such that the latest one (which is less that baseRev) is very old
> , finding newest revision traverses a lot of previous docs. Since root document gets split a lot and is a very common commitRoot (thus participating during checkConflicts in lot of commits), the issue can slow down commits by a lot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)