You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Gary Gregory <ga...@gmail.com> on 2019/05/31 18:16:41 UTC

Re: [httpcomponents-core] branch message-support updated (d31f4ff -> 1a3aff6)

Unless I am missing something, this kind of large change set tells me we
are not quite ready for 5.0 but at least one or two more betas will be a
good thing.

Gary

On Fri, May 31, 2019 at 1:51 PM <ol...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> olegk pushed a change to branch message-support
> in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git.
>
>
>  discard d31f4ff  Basic message consumer simplifications and improvements
>      add 5b52519  [HTTPCORE-578] Incorrect serialization of HeaderGroup
> #127.
>      new ecdebe1  Code formatting (no functional changes)
>      new 8ddd7dc  Escape DEL character when tracing
>      new 44a82e9  Basic message consumer simplifications and improvements
>      new 0e96b7d  Improved classic and async entity factory methods
>      new fe6d9ca  Classic and async message builders
>      new 1a3aff6  Fixed parameter inconsistency in server side push APIs
>
> This update added new revisions after undoing existing revisions.
> That is to say, some revisions that were in the old version of the
> branch are not in the new version.  This situation occurs
> when a user --force pushes a change and generates a repository
> containing something like this:
>
>  * -- * -- B -- O -- O -- O   (d31f4ff)
>             \
>              N -- N -- N   refs/heads/message-support (1a3aff6)
>
> You should already have received notification emails for all of the O
> revisions, and so the following emails describe only the N revisions
> from the common base, B.
>
> Any revisions marked "omit" are not gone; other references still
> refer to them.  Any revisions marked "discard" are gone forever.
>
> The 6 revisions listed above as "new" are entirely new to this
> repository and will be described in separate emails.  The revisions
> listed as "add" were already present in the repository and have only
> been added to this reference.
>
>
> Summary of changes:
>  RELEASE_NOTES.txt                                  |   4 +
>  .../http2/impl/nio/ServerHttp2StreamHandler.java   |   2 +-
>  .../impl/nio/ServerPushHttp2StreamHandler.java     |   2 +-
>  .../Http2ConscriptRequestExecutionExample.java     |   4 +-
>  .../http2/examples/Http2FileServerExample.java     |  33 +-
>  .../examples/Http2FullDuplexClientExample.java     |  13 +-
>  .../examples/Http2MultiStreamExecutionExample.java |   4 +-
>  .../examples/Http2RequestExecutionExample.java     |   4 +-
>  .../Http2TlsAlpnRequestExecutionExample.java       |   4 +-
>  .../examples/ReactiveFullDuplexClientExample.java  |  13 +-
>  .../org/apache/hc/core5/testing/classic/Wire.java  |  13 +-
>  .../hc/core5/benchmark/BenchmarkToolTest.java      |  10 +-
>  .../http2/Http2CompatibilityTest.java              |   4 +-
>  .../core5/testing/nio/Http1AuthenticationTest.java |  16 +-
>  .../hc/core5/testing/nio/Http1IntegrationTest.java |  38 +-
>  .../testing/nio/Http1ServerAndRequesterTest.java   |   4 +-
>  .../apache/hc/core5/testing/nio/Http2AlpnTest.java |   4 +-
>  .../hc/core5/testing/nio/Http2IntegrationTest.java |  30 +-
>  .../testing/nio/Http2ProtocolNegotiationTest.java  |   4 +-
>  .../Http2ServerAndMultiplexingRequesterTest.java   |   4 +-
>  .../testing/nio/Http2ServerAndRequesterTest.java   |   4 +-
>  .../core5/testing/nio/MessageExchangeHandler.java  |   2 +-
>  .../testing/nio/MultiLineResponseHandler.java      |  15 +-
>  .../testing/nio/SingleLineResponseHandler.java     |  12 +-
>  .../core5/testing/reactive/ReactiveClientTest.java |   2 +-
>  .../http/impl/nio/ServerHttp1StreamHandler.java    |   2 +-
>  .../hc/core5/http/impl/nio/ServerSupport.java      |   2 +-
>  .../hc/core5/http/io/entity/EntityTemplate.java    |  12 +-
>  .../hc/core5/http/io/entity/EntityUtils.java       |   2 +-
>  .../core5/http/io/entity/HttpContentProducer.java  |  44 ---
>  .../hc/core5/http/io/entity/HttpEntities.java      | 224 +++++++++++
>  .../hc/core5/http/io/entity/HttpEntityWrapper.java |   8 +-
>  .../http/io/support/ClassicRequestBuilder.java     | 419
> ++++++++++++++++++++
>  .../http/io/support/ClassicResponseBuilder.java    | 203 ++++++++++
>  .../apache/hc/core5/http/nio/ResponseChannel.java  |   4 +-
>  .../entity/AsyncEntityProducerWrapper.java}        |  74 ++--
>  .../http/nio/entity/AsyncEntityProducers.java      | 235 ++++++++++++
>  .../nio/support/AbstractAsyncServerAuthFilter.java |   4 +-
>  .../nio/support/AbstractServerExchangeHandler.java |   8 +-
>  .../core5/http/nio/support/AsyncPushBuilder.java   | 187 +++++++++
>  .../http/nio/support/AsyncRequestBuilder.java      | 424
> +++++++++++++++++++++
>  .../http/nio/support/AsyncResponseBuilder.java     | 203 ++++++++++
>  ...yncServerFilterChainExchangeHandlerFactory.java |   3 +-
>  .../http/nio/{ => support}/BasicPushProducer.java  |   6 +-
>  .../nio/{ => support}/BasicRequestConsumer.java    |   5 +-
>  .../nio/{ => support}/BasicRequestProducer.java    |   6 +-
>  .../nio/{ => support}/BasicResponseConsumer.java   |   5 +-
>  .../nio/{ => support}/BasicResponseProducer.java   |  10 +-
>  .../support/ImmediateResponseExchangeHandler.java  |   6 +-
>  .../nio/support/TerminalAsyncServerFilter.java     |   6 +-
>  .../core5/io/{CloseMode.java => IOCallback.java}   |   8 +-
>  .../org/apache/hc/core5/net/URLEncodedUtils.java   |   5 -
>  .../http/examples/AsyncFileServerExample.java      |  34 +-
>  .../examples/AsyncFullDuplexClientExample.java     |  13 +-
>  .../AsyncPipelinedRequestExecutionExample.java     |   4 +-
>  .../examples/AsyncRequestExecutionExample.java     |   4 +-
>  .../http/examples/AsyncServerFilterExample.java    |  17 +-
>  .../http/examples/ClassicPostExecutionExample.java |  36 +-
>  .../ClassicPostWithTrailersExecutionExample.java   |  78 ----
>  .../hc/core5/http/io/entity/TestEntityUtils.java   |   2 +-
>  .../hc/core5/http/message/TestMessageSupport.java  |  10 +-
>  .../http/protocol/TestStandardInterceptors.java    |   6 +-
>  62 files changed, 2178 insertions(+), 386 deletions(-)
>  delete mode 100644
> httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpContentProducer.java
>  create mode 100644
> httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpEntities.java
>  create mode 100644
> httpcore5/src/main/java/org/apache/hc/core5/http/io/support/ClassicRequestBuilder.java
>  create mode 100644
> httpcore5/src/main/java/org/apache/hc/core5/http/io/support/ClassicResponseBuilder.java
>  rename
> httpcore5/src/main/java/org/apache/hc/core5/http/{io/entity/HttpEntityWithTrailers.java
> => nio/entity/AsyncEntityProducerWrapper.java} (52%)
>  create mode 100644
> httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/AsyncEntityProducers.java
>  create mode 100644
> httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/AsyncPushBuilder.java
>  create mode 100644
> httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/AsyncRequestBuilder.java
>  create mode 100644
> httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/AsyncResponseBuilder.java
>  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> support}/BasicPushProducer.java (92%)
>  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> support}/BasicRequestConsumer.java (96%)
>  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> support}/BasicRequestProducer.java (94%)
>  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> support}/BasicResponseConsumer.java (96%)
>  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> support}/BasicResponseProducer.java (90%)
>  copy httpcore5/src/main/java/org/apache/hc/core5/io/{CloseMode.java =>
> IOCallback.java} (90%)
>  delete mode 100644
> httpcore5/src/test/java/org/apache/hc/core5/http/examples/ClassicPostWithTrailersExecutionExample.java
>
>

Re: [httpcomponents-core] branch message-support updated (d31f4ff -> 1a3aff6)

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2019-05-31 at 14:16 -0400, Gary Gregory wrote:
> Unless I am missing something, this kind of large change set tells me
> we
> are not quite ready for 5.0 but at least one or two more betas will
> be a
> good thing.
> 

This is likely to be my last large change-set for HttpCore 5.0 GA. It
is mostly support code anyway. 

As far as I am concerned I am done.

Oleg


> Gary
> 
> On Fri, May 31, 2019 at 1:51 PM <ol...@apache.org> wrote:
> 
> > This is an automated email from the ASF dual-hosted git repository.
> > 
> > olegk pushed a change to branch message-support
> > in repository 
> > https://gitbox.apache.org/repos/asf/httpcomponents-core.git.
> > 
> > 
> >  discard d31f4ff  Basic message consumer simplifications and
> > improvements
> >      add 5b52519  [HTTPCORE-578] Incorrect serialization of
> > HeaderGroup
> > #127.
> >      new ecdebe1  Code formatting (no functional changes)
> >      new 8ddd7dc  Escape DEL character when tracing
> >      new 44a82e9  Basic message consumer simplifications and
> > improvements
> >      new 0e96b7d  Improved classic and async entity factory methods
> >      new fe6d9ca  Classic and async message builders
> >      new 1a3aff6  Fixed parameter inconsistency in server side push
> > APIs
> > 
> > This update added new revisions after undoing existing revisions.
> > That is to say, some revisions that were in the old version of the
> > branch are not in the new version.  This situation occurs
> > when a user --force pushes a change and generates a repository
> > containing something like this:
> > 
> >  * -- * -- B -- O -- O -- O   (d31f4ff)
> >             \
> >              N -- N -- N   refs/heads/message-support (1a3aff6)
> > 
> > You should already have received notification emails for all of the
> > O
> > revisions, and so the following emails describe only the N
> > revisions
> > from the common base, B.
> > 
> > Any revisions marked "omit" are not gone; other references still
> > refer to them.  Any revisions marked "discard" are gone forever.
> > 
> > The 6 revisions listed above as "new" are entirely new to this
> > repository and will be described in separate emails.  The revisions
> > listed as "add" were already present in the repository and have
> > only
> > been added to this reference.
> > 
> > 
> > Summary of changes:
> >  RELEASE_NOTES.txt                                  |   4 +
> >  .../http2/impl/nio/ServerHttp2StreamHandler.java   |   2 +-
> >  .../impl/nio/ServerPushHttp2StreamHandler.java     |   2 +-
> >  .../Http2ConscriptRequestExecutionExample.java     |   4 +-
> >  .../http2/examples/Http2FileServerExample.java     |  33 +-
> >  .../examples/Http2FullDuplexClientExample.java     |  13 +-
> >  .../examples/Http2MultiStreamExecutionExample.java |   4 +-
> >  .../examples/Http2RequestExecutionExample.java     |   4 +-
> >  .../Http2TlsAlpnRequestExecutionExample.java       |   4 +-
> >  .../examples/ReactiveFullDuplexClientExample.java  |  13 +-
> >  .../org/apache/hc/core5/testing/classic/Wire.java  |  13 +-
> >  .../hc/core5/benchmark/BenchmarkToolTest.java      |  10 +-
> >  .../http2/Http2CompatibilityTest.java              |   4 +-
> >  .../core5/testing/nio/Http1AuthenticationTest.java |  16 +-
> >  .../hc/core5/testing/nio/Http1IntegrationTest.java |  38 +-
> >  .../testing/nio/Http1ServerAndRequesterTest.java   |   4 +-
> >  .../apache/hc/core5/testing/nio/Http2AlpnTest.java |   4 +-
> >  .../hc/core5/testing/nio/Http2IntegrationTest.java |  30 +-
> >  .../testing/nio/Http2ProtocolNegotiationTest.java  |   4 +-
> >  .../Http2ServerAndMultiplexingRequesterTest.java   |   4 +-
> >  .../testing/nio/Http2ServerAndRequesterTest.java   |   4 +-
> >  .../core5/testing/nio/MessageExchangeHandler.java  |   2 +-
> >  .../testing/nio/MultiLineResponseHandler.java      |  15 +-
> >  .../testing/nio/SingleLineResponseHandler.java     |  12 +-
> >  .../core5/testing/reactive/ReactiveClientTest.java |   2 +-
> >  .../http/impl/nio/ServerHttp1StreamHandler.java    |   2 +-
> >  .../hc/core5/http/impl/nio/ServerSupport.java      |   2 +-
> >  .../hc/core5/http/io/entity/EntityTemplate.java    |  12 +-
> >  .../hc/core5/http/io/entity/EntityUtils.java       |   2 +-
> >  .../core5/http/io/entity/HttpContentProducer.java  |  44 ---
> >  .../hc/core5/http/io/entity/HttpEntities.java      | 224
> > +++++++++++
> >  .../hc/core5/http/io/entity/HttpEntityWrapper.java |   8 +-
> >  .../http/io/support/ClassicRequestBuilder.java     | 419
> > ++++++++++++++++++++
> >  .../http/io/support/ClassicResponseBuilder.java    | 203
> > ++++++++++
> >  .../apache/hc/core5/http/nio/ResponseChannel.java  |   4 +-
> >  .../entity/AsyncEntityProducerWrapper.java}        |  74 ++--
> >  .../http/nio/entity/AsyncEntityProducers.java      | 235
> > ++++++++++++
> >  .../nio/support/AbstractAsyncServerAuthFilter.java |   4 +-
> >  .../nio/support/AbstractServerExchangeHandler.java |   8 +-
> >  .../core5/http/nio/support/AsyncPushBuilder.java   | 187 +++++++++
> >  .../http/nio/support/AsyncRequestBuilder.java      | 424
> > +++++++++++++++++++++
> >  .../http/nio/support/AsyncResponseBuilder.java     | 203
> > ++++++++++
> >  ...yncServerFilterChainExchangeHandlerFactory.java |   3 +-
> >  .../http/nio/{ => support}/BasicPushProducer.java  |   6 +-
> >  .../nio/{ => support}/BasicRequestConsumer.java    |   5 +-
> >  .../nio/{ => support}/BasicRequestProducer.java    |   6 +-
> >  .../nio/{ => support}/BasicResponseConsumer.java   |   5 +-
> >  .../nio/{ => support}/BasicResponseProducer.java   |  10 +-
> >  .../support/ImmediateResponseExchangeHandler.java  |   6 +-
> >  .../nio/support/TerminalAsyncServerFilter.java     |   6 +-
> >  .../core5/io/{CloseMode.java => IOCallback.java}   |   8 +-
> >  .../org/apache/hc/core5/net/URLEncodedUtils.java   |   5 -
> >  .../http/examples/AsyncFileServerExample.java      |  34 +-
> >  .../examples/AsyncFullDuplexClientExample.java     |  13 +-
> >  .../AsyncPipelinedRequestExecutionExample.java     |   4 +-
> >  .../examples/AsyncRequestExecutionExample.java     |   4 +-
> >  .../http/examples/AsyncServerFilterExample.java    |  17 +-
> >  .../http/examples/ClassicPostExecutionExample.java |  36 +-
> >  .../ClassicPostWithTrailersExecutionExample.java   |  78 ----
> >  .../hc/core5/http/io/entity/TestEntityUtils.java   |   2 +-
> >  .../hc/core5/http/message/TestMessageSupport.java  |  10 +-
> >  .../http/protocol/TestStandardInterceptors.java    |   6 +-
> >  62 files changed, 2178 insertions(+), 386 deletions(-)
> >  delete mode 100644
> > httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpCont
> > entProducer.java
> >  create mode 100644
> > httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/HttpEnti
> > ties.java
> >  create mode 100644
> > httpcore5/src/main/java/org/apache/hc/core5/http/io/support/Classic
> > RequestBuilder.java
> >  create mode 100644
> > httpcore5/src/main/java/org/apache/hc/core5/http/io/support/Classic
> > ResponseBuilder.java
> >  rename
> > httpcore5/src/main/java/org/apache/hc/core5/http/{io/entity/HttpEnt
> > ityWithTrailers.java
> > => nio/entity/AsyncEntityProducerWrapper.java} (52%)
> >  create mode 100644
> > httpcore5/src/main/java/org/apache/hc/core5/http/nio/entity/AsyncEn
> > tityProducers.java
> >  create mode 100644
> > httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/AsyncP
> > ushBuilder.java
> >  create mode 100644
> > httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/AsyncR
> > equestBuilder.java
> >  create mode 100644
> > httpcore5/src/main/java/org/apache/hc/core5/http/nio/support/AsyncR
> > esponseBuilder.java
> >  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> > support}/BasicPushProducer.java (92%)
> >  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> > support}/BasicRequestConsumer.java (96%)
> >  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> > support}/BasicRequestProducer.java (94%)
> >  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> > support}/BasicResponseConsumer.java (96%)
> >  rename httpcore5/src/main/java/org/apache/hc/core5/http/nio/{ =>
> > support}/BasicResponseProducer.java (90%)
> >  copy
> > httpcore5/src/main/java/org/apache/hc/core5/io/{CloseMode.java =>
> > IOCallback.java} (90%)
> >  delete mode 100644
> > httpcore5/src/test/java/org/apache/hc/core5/http/examples/ClassicPo
> > stWithTrailersExecutionExample.java
> > 
> > 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org