You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "petrov-mg (via GitHub)" <gi...@apache.org> on 2026/08/09 20:45:16 UTC
[PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
petrov-mg opened a new pull request, #13456:
URL: https://github.com/apache/ignite/pull/13456
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13456:
URL: https://github.com/apache/ignite/pull/13456#issuecomment-5236858835
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/IgnitePluginFeatureSet.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeRequest.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg commented on code in PR #13456:
URL: https://github.com/apache/ignite/pull/13456#discussion_r3747968846
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -1597,6 +1600,16 @@ else if (U.millisSinceNanos(joinStartNanos) > spi.joinTimeout)
errs.add(e);
+ if (e instanceof UnsupportedNodeVersionException) {
+ LT.error(log, e, "Failed to initialize a connection with the remote node. The remote node is running" +
+ " components with an incompatible versions, so the nodes cannot agree on serialization protocol" +
+ " [rmtAddr=" + addr + ']');
Review Comment:
Regarding the separate catch block: the issue is that in places like this we don’t just log the exception and rethrow it—we also close sockets, call onException, and perform other cleanup.
I’m concerned that duplicating the exception-handling logic could introduce more problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13456:
URL: https://github.com/apache/ignite/pull/13456#issuecomment-5233759862
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeRequest.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg commented on code in PR #13456:
URL: https://github.com/apache/ignite/pull/13456#discussion_r3747968846
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -1597,6 +1600,16 @@ else if (U.millisSinceNanos(joinStartNanos) > spi.joinTimeout)
errs.add(e);
+ if (e instanceof UnsupportedNodeVersionException) {
+ LT.error(log, e, "Failed to initialize a connection with the remote node. The remote node is running" +
+ " components with an incompatible versions, so the nodes cannot agree on serialization protocol" +
+ " [rmtAddr=" + addr + ']');
Review Comment:
Regarding the separate catch block: the issue is that in places like this we don’t just log the exception and rethrow it—we also close sockets, call onException, and perform other cleanup.
I’m concerned that duplicating the exception-handling logic could introduce problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg merged PR #13456:
URL: https://github.com/apache/ignite/pull/13456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "sergey-chugunov-1985 (via GitHub)" <gi...@apache.org>.
sergey-chugunov-1985 commented on code in PR #13456:
URL: https://github.com/apache/ignite/pull/13456#discussion_r3747325254
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -1597,6 +1600,16 @@ else if (U.millisSinceNanos(joinStartNanos) > spi.joinTimeout)
errs.add(e);
+ if (e instanceof UnsupportedNodeVersionException) {
+ LT.error(log, e, "Failed to initialize a connection with the remote node. The remote node is running" +
+ " components with an incompatible versions, so the nodes cannot agree on serialization protocol" +
+ " [rmtAddr=" + addr + ']');
Review Comment:
It may be a good idea to include error message from UnsupportedNodeVersionException to the log entry printed here.
Also why not to move this logic into a separate catch block handling UnsupportedNodeVersionException specifically?
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java:
##########
@@ -1686,6 +1694,40 @@ Socket createSocket() throws IOException {
}
}
+ /** */
+ IgniteNodeFeatureSet localNodeFeatures() {
+ return locNodeFeatures;
+ }
+
+ /** */
+ void validateRemoteFeatures(IgniteNodeFeatureSet rmtFeatures) throws IgniteCheckedException {
+ if (rmtFeatures == null)
+ throw new UnsupportedNodeVersionException("Remote node component versions are not supported" +
+ " [locComponents=" + locNodeFeatures +
+ ", rmtComponents=" + rmtFeatures + ']');
+
+ for (IgniteComponentFeatureSet rmtCmpFeatures : rmtFeatures.values()) {
+ IgniteComponentFeatureSet locCmpFeatures = locNodeFeatures.componentFeatures(rmtCmpFeatures.componentName());
+
+ if (locCmpFeatures == null)
+ continue;
+
+ int c = locCmpFeatures.version().compareTo(rmtCmpFeatures.version());
+
+ if (c == 0)
+ continue;
+
+ IgniteComponentFeatureSet src = c > 0 ? rmtCmpFeatures : locCmpFeatures;
+ IgniteComponentFeatureSet target = c > 0 ? locCmpFeatures : rmtCmpFeatures;
+
+ if (!src.isUpgradableTo(target)) {
+ throw new UnsupportedNodeVersionException("Remote node component versions are not supported" +
Review Comment:
I suggest to use different error message here instead of reusing the same message as for the situation when remote node features are null.
This would allow users to distinguish these situations, right now it is not possible solely by error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg commented on code in PR #13456:
URL: https://github.com/apache/ignite/pull/13456#discussion_r3747970217
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpi.java:
##########
@@ -1686,6 +1694,40 @@ Socket createSocket() throws IOException {
}
}
+ /** */
+ IgniteNodeFeatureSet localNodeFeatures() {
+ return locNodeFeatures;
+ }
+
+ /** */
+ void validateRemoteFeatures(IgniteNodeFeatureSet rmtFeatures) throws IgniteCheckedException {
+ if (rmtFeatures == null)
+ throw new UnsupportedNodeVersionException("Remote node component versions are not supported" +
+ " [locComponents=" + locNodeFeatures +
+ ", rmtComponents=" + rmtFeatures + ']');
+
+ for (IgniteComponentFeatureSet rmtCmpFeatures : rmtFeatures.values()) {
+ IgniteComponentFeatureSet locCmpFeatures = locNodeFeatures.componentFeatures(rmtCmpFeatures.componentName());
+
+ if (locCmpFeatures == null)
+ continue;
+
+ int c = locCmpFeatures.version().compareTo(rmtCmpFeatures.version());
+
+ if (c == 0)
+ continue;
+
+ IgniteComponentFeatureSet src = c > 0 ? rmtCmpFeatures : locCmpFeatures;
+ IgniteComponentFeatureSet target = c > 0 ? locCmpFeatures : rmtCmpFeatures;
+
+ if (!src.isUpgradableTo(target)) {
+ throw new UnsupportedNodeVersionException("Remote node component versions are not supported" +
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13456:
URL: https://github.com/apache/ignite/pull/13456#issuecomment-5237879056
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/IgnitePluginFeatureSet.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeRequest.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "petrov-mg (via GitHub)" <gi...@apache.org>.
petrov-mg commented on code in PR #13456:
URL: https://github.com/apache/ignite/pull/13456#discussion_r3747972665
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -1597,6 +1600,16 @@ else if (U.millisSinceNanos(joinStartNanos) > spi.joinTimeout)
errs.add(e);
+ if (e instanceof UnsupportedNodeVersionException) {
+ LT.error(log, e, "Failed to initialize a connection with the remote node. The remote node is running" +
+ " components with an incompatible versions, so the nodes cannot agree on serialization protocol" +
+ " [rmtAddr=" + addr + ']');
Review Comment:
> It may be a good idea to include error message from UnsupportedNodeVersionException to the log entry printed here.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13456:
URL: https://github.com/apache/ignite/pull/13456#issuecomment-5237950951
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/IgnitePluginFeatureSet.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeRequest.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28969 Added remote node features validation during the TCP Discovery handshake [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13456:
URL: https://github.com/apache/ignite/pull/13456#issuecomment-5238815565
<!-- ignite-rolling-upgrade-check -->
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/core/src/main/java/org/apache/ignite/internal/processors/rollingupgrade/feature/IgnitePluginFeatureSet.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeRequest.java`
- `modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org