You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/01/10 02:34:51 UTC

[PR] [SPARK-46645][INFRA] Exclude unittest-xml-reporting in Python 3.12 image [spark]

HyukjinKwon opened a new pull request, #44652:
URL: https://github.com/apache/spark/pull/44652

   ### What changes were proposed in this pull request?
   
   This PR proposes to exclude unittest-xml-reporting in Python 3.12 image
   
   ### Why are the changes needed?
   
   `unittest-xml-reporting` seems not supporting, and this seems hiding the real error:
   
   ```
     File "/__w/spark/spark/python/pyspark/streaming/tests/test_kinesis.py", line 118, in <module>
       unittest.main(testRunner=testRunner, verbosity=2)
     File "/usr/lib/python3.12/unittest/main.py", line 105, in __init__
       self.runTests()
     File "/usr/lib/python3.12/unittest/main.py", line 281, in runTests
       self.result = testRunner.run(self.test)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/local/lib/python3.12/dist-packages/xmlrunner/runner.py", line 67, in run
       test(result)
     File "/usr/lib/python3.12/unittest/suite.py", line 84, in __call__
       return self.run(*args, **kwds)
              ^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/lib/python3.12/unittest/suite.py", line 122, in run
       test(result)
     File "/usr/lib/python3.12/unittest/suite.py", line 84, in __call__
       return self.run(*args, **kwds)
              ^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/lib/python3.12/unittest/suite.py", line 122, in run
       test(result)
     File "/usr/lib/python3.12/unittest/case.py", line 692, in __call__
       return self.run(*args, **kwds)
              ^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/lib/python3.12/unittest/case.py", line 662, in run
       result.stopTest(self)
     File "/usr/local/lib/python3.12/dist-packages/xmlrunner/result.py", line 327, in stopTest
       self.callback()
     File "/usr/local/lib/python3.12/dist-packages/xmlrunner/result.py", line 235, in callback
       test_info.test_finished()
     File "/usr/local/lib/python3.12/dist-packages/xmlrunner/result.py", line 180, in test_finished
       self.test_result.stop_time - self.test_result.start_time
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   AttributeError: '_XMLTestResult' object has no attribute 'start_time'. Did you mean: 'stop_time'?
   ```
   
   This is optional dependency in testing so we can exclude this (see https://github.com/apache/spark/actions/runs/7462843546/job/20306214215)
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   CI in this PR should test it out.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Np.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46645][INFRA] Exclude unittest-xml-reporting in Python 3.12 image [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44652:
URL: https://github.com/apache/spark/pull/44652#issuecomment-1884132221

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46645][INFRA] Exclude unittest-xml-reporting in Python 3.12 image [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44652: [SPARK-46645][INFRA] Exclude unittest-xml-reporting in Python 3.12 image
URL: https://github.com/apache/spark/pull/44652


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org