You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "danepitkin (via GitHub)" <gi...@apache.org> on 2023/11/29 02:42:47 UTC
[PR] Fix valueCount when loading NullVector [arrow]
danepitkin opened a new pull request, #38973:
URL: https://github.com/apache/arrow/pull/38973
### Rationale for this change
This is a follow up of https://github.com/apache/arrow/pull/34611 (thanks @sunchao)
We should set `valueCount` when loading `NullVector`. Unfortunately there's no `nullCount` field.
### What changes are included in this PR?
* `valueCount` added to NullVector
* `name` added to NullVector's TransferPair
### Are these changes tested?
Yes. unit tested.
### Are there any user-facing changes?
Yes, a NullVector with a non-null name will maintain the name when transferred via `TransferPair` instead of defaulting to the default name `$data$`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-34610: [Java] Fix valueCount and field name when loading/transferring NullVector [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #38973:
URL: https://github.com/apache/arrow/pull/38973#issuecomment-1832066421
Thanks, @pitrou !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-34610: [Java] Fix valueCount and field name when loading/transferring NullVector [arrow]
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao commented on PR #38973:
URL: https://github.com/apache/arrow/pull/38973#issuecomment-1832477321
Thanks for following up on this @danepitkin !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-34610: [Java] Fix valueCount and field name when loading/transferring NullVector [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #38973:
URL: https://github.com/apache/arrow/pull/38973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-34610: [Java] Fix valueCount when loading NullVector [arrow]
Posted by "danepitkin (via GitHub)" <gi...@apache.org>.
danepitkin commented on PR #38973:
URL: https://github.com/apache/arrow/pull/38973#issuecomment-1831967946
> Is this what's tested in the added test?
Yes, the test is naming the null vector "v", which was failing without the changes to TransferPairImpl. The roundtrip helper test function invokes the transfer apis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-34610: [Java] Fix valueCount when loading NullVector [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38973:
URL: https://github.com/apache/arrow/pull/38973#issuecomment-1831932625
> Yes, a NullVector with a non-null name will maintain the name when transferred via TransferPair instead of defaulting to the default name $data$.
Is this what's tested in the added test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-34610: [Java] Fix valueCount and field name when loading/transferring NullVector [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38973:
URL: https://github.com/apache/arrow/pull/38973#issuecomment-1834569429
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit a31663ad9942338a8a835702504634743bffc8be.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/19197163867) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org