You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/04 20:09:09 UTC
[GitHub] [skywalking] BFergerson opened a new pull request, #9909: Silent NPE fix
BFergerson opened a new pull request, #9909:
URL: https://github.com/apache/skywalking/pull/9909
I don't think this change has much affect but noticed that a NPE was being thrown when https://github.com/apache/skywalking/blob/d32a318637bc506364928456aff0f5b02f9bc9c9/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java#L129-L131 is called on the first pass. Since `bulkProcessor` isn't set till https://github.com/apache/skywalking/blob/d32a318637bc506364928456aff0f5b02f9bc9c9/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java#L135 so calling `endOfFlush` throws silent NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9909: Silent NPE fix
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9909:
URL: https://github.com/apache/skywalking/pull/9909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org