You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/25 01:27:10 UTC
Review Request 36803: Added helpers for converting scheduler messages
to Events.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36803/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Ben Mahler.
Repository: mesos
Description
-------
Added helpers for converting scheduler messages to Events.
Diffs
-----
src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab
src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594
src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3
Diff: https://reviews.apache.org/r/36803/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 36803: Added helpers for converting scheduler
messages to Events.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36803/#review93012
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 24, 2015, 11:27 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36803/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 11:27 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helpers for converting scheduler messages to Events.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab
> src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594
> src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3
>
> Diff: https://reviews.apache.org/r/36803/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36803: Added helpers for converting scheduler
messages to Events.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36803/#review93014
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36803]
All tests passed.
- Mesos ReviewBot
On July 24, 2015, 11:27 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36803/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 11:27 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helpers for converting scheduler messages to Events.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab
> src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594
> src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3
>
> Diff: https://reviews.apache.org/r/36803/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>