You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/01/09 22:37:14 UTC
Re: Review Request 49571: Added a benchmark test for allocations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Jan. 9, 2017, 10:37 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebase.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
src/tests/resources_utils.hpp 18dcca7f171102df8fe88f10785f70c5d1cf5b32
src/tests/resources_utils.cpp be1feb97be552af582dbba3a54fa5fa0714b3eb2
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 10%) on runtime performance in allocations as compared to HEAD (without shared resources). Also, there is no visible impact in performance when shared resources are added in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6907us
Added 1000 agents in 2.057098secs
round 0 allocate() took 1.689164secs to make 1000 offers
round 50 allocate() took 1.672373secs to make 1000 offers
round 100 allocate() took 1.680571secs to make 1000 offers
round 150 allocate() took 1.674683secs to make 1000 offers
round 199 allocate() took 1.671525secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6888us
Added 1000 agents in 2.096218secs
round 0 allocate() took 1.704491secs to make 1000 offers
round 50 allocate() took 1.718623secs to make 1000 offers
round 100 allocate() took 1.716224secs to make 1000 offers
round 150 allocate() took 1.707343secs to make 1000 offers
round 199 allocate() took 1.727467secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 7304us
Added 1000 agents in 2.071009secs
round 0 allocate() took 1.689045secs to make 1000 offers
round 50 allocate() took 1.691524secs to make 1000 offers
round 100 allocate() took 1.688873secs to make 1000 offers
round 150 allocate() took 1.688713secs to make 1000 offers
round 199 allocate() took 1.691223secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review175857
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53096, 45962, 55359, 49571]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 23, 2017, 6:59 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 6:59 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-5771
> https://issues.apache.org/jira/browse/MESOS-5771
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allocations test has the following resource configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
> resources; and offers from every other alternate slave contains
> a shared resource.
>
> This test is parameterized based on number of agents, number of
> frameworks and resource configuration.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 6dee2296d5a14185dbf7eee17968b20148839bfd
> src/tests/resources_utils.hpp 1f41f02babce5c8174ea2223f4dc7470452fbaf1
> src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff
>
>
> Diff: https://reviews.apache.org/r/49571/diff/35/
>
>
> Testing
> -------
>
> All tests passed.
>
> Allocations benchmark test results
> ==================================
> There is no visible impact in performance when shared resources are added in the allocations. The numbers for HEAD are prior to shared resources support (mid 2016) and the numbers indicate improvements in allocations during this timeframe.
>
> Following is a snapshot with 1000 agents and 200 frameworks.
>
> With the patch (and no shared resources)
> ----------------------------------------
> [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
> Using 1000 agents and 200 frameworks with resource type 0
> Added 200 frameworks in 6588us
> Added 1000 agents in 1.567347secs
> round 0 allocate() took 1.15531secs to make 1000 offers
> round 10 allocate() took 1.152876secs to make 1000 offers
> round 20 allocate() took 1.15661secs to make 1000 offers
> round 30 allocate() took 1.117733secs to make 1000 offers
> round 40 allocate() took 1.118754secs to make 1000 offers
> round 50 allocate() took 1.11169secs to make 1000 offers
>
> With the patch (and shared resources on all agents)
> ---------------------------------------------------
> [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
> Using 1000 agents and 200 frameworks with resource type 1
> Added 200 frameworks in 6064us
> Added 1000 agents in 1.627008secs
> round 0 allocate() took 1.168253secs to make 1000 offers
> round 10 allocate() took 1.146421secs to make 1000 offers
> round 20 allocate() took 1.16416secs to make 1000 offers
> round 30 allocate() took 1.210476secs to make 1000 offers
> round 40 allocate() took 1.194251secs to make 1000 offers
> round 50 allocate() took 1.17789secs to make 1000 offers
>
> With the patch (and shared resources on alternate agents)
> ---------------------------------------------------------
> [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
> Using 1000 agents and 200 frameworks with resource type 2
> Added 200 frameworks in 6466us
> Added 1000 agents in 1.568717secs
> round 0 allocate() took 1.153005secs to make 1000 offers
> round 10 allocate() took 1.168169secs to make 1000 offers
> round 20 allocate() took 1.156774secs to make 1000 offers
> round 30 allocate() took 1.183112secs to make 1000 offers
> round 40 allocate() took 1.202452secs to make 1000 offers
> round 50 allocate() took 1.198918secs to make 1000 offers
>
> Based on HEAD, with all regular resources (no shared resources in HEAD supported)
> ---------------------------------------------------------------------------------
> [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
> Using 1000 agents and 200 frameworks with resource type 0
> Added 200 frameworks in 6801us
> Added 1000 agents in 1.721447secs
> round 0 allocate() took 1.502953secs to make 1000 offers
> round 50 allocate() took 1.520157secs to make 1000 offers
> round 100 allocate() took 1.517221secs to make 1000 offers
> round 150 allocate() took 1.526446secs to make 1000 offers
> round 199 allocate() took 1.538005secs to make 1000 offers
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated May 23, 2017, 6:59 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased to incorporate `AllocationInfo`.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 6dee2296d5a14185dbf7eee17968b20148839bfd
src/tests/resources_utils.hpp 1f41f02babce5c8174ea2223f4dc7470452fbaf1
src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff
Diff: https://reviews.apache.org/r/49571/diff/35/
Changes: https://reviews.apache.org/r/49571/diff/34-35/
Testing (updated)
-------
All tests passed.
Allocations benchmark test results
==================================
There is no visible impact in performance when shared resources are added in the allocations. The numbers for HEAD are prior to shared resources support (mid 2016) and the numbers indicate improvements in allocations during this timeframe.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6588us
Added 1000 agents in 1.567347secs
round 0 allocate() took 1.15531secs to make 1000 offers
round 10 allocate() took 1.152876secs to make 1000 offers
round 20 allocate() took 1.15661secs to make 1000 offers
round 30 allocate() took 1.117733secs to make 1000 offers
round 40 allocate() took 1.118754secs to make 1000 offers
round 50 allocate() took 1.11169secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6064us
Added 1000 agents in 1.627008secs
round 0 allocate() took 1.168253secs to make 1000 offers
round 10 allocate() took 1.146421secs to make 1000 offers
round 20 allocate() took 1.16416secs to make 1000 offers
round 30 allocate() took 1.210476secs to make 1000 offers
round 40 allocate() took 1.194251secs to make 1000 offers
round 50 allocate() took 1.17789secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 6466us
Added 1000 agents in 1.568717secs
round 0 allocate() took 1.153005secs to make 1000 offers
round 10 allocate() took 1.168169secs to make 1000 offers
round 20 allocate() took 1.156774secs to make 1000 offers
round 30 allocate() took 1.183112secs to make 1000 offers
round 40 allocate() took 1.202452secs to make 1000 offers
round 50 allocate() took 1.198918secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Feb. 27, 2017, 8:50 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
src/tests/resources_utils.hpp 1f41f02babce5c8174ea2223f4dc7470452fbaf1
src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 10%) on runtime performance in allocations as compared to HEAD (without shared resources). Also, there is no visible impact in performance when shared resources are added in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6907us
Added 1000 agents in 2.057098secs
round 0 allocate() took 1.689164secs to make 1000 offers
round 50 allocate() took 1.672373secs to make 1000 offers
round 100 allocate() took 1.680571secs to make 1000 offers
round 150 allocate() took 1.674683secs to make 1000 offers
round 199 allocate() took 1.671525secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6888us
Added 1000 agents in 2.096218secs
round 0 allocate() took 1.704491secs to make 1000 offers
round 50 allocate() took 1.718623secs to make 1000 offers
round 100 allocate() took 1.716224secs to make 1000 offers
round 150 allocate() took 1.707343secs to make 1000 offers
round 199 allocate() took 1.727467secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 7304us
Added 1000 agents in 2.071009secs
round 0 allocate() took 1.689045secs to make 1000 offers
round 50 allocate() took 1.691524secs to make 1000 offers
round 100 allocate() took 1.688873secs to make 1000 offers
round 150 allocate() took 1.688713secs to make 1000 offers
round 199 allocate() took 1.691223secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 5:02 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp c681d03c3f94f7d071143366a5aad0421108ebec
src/tests/resources_utils.hpp 1f41f02babce5c8174ea2223f4dc7470452fbaf1
src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 10%) on runtime performance in allocations as compared to HEAD (without shared resources). Also, there is no visible impact in performance when shared resources are added in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6907us
Added 1000 agents in 2.057098secs
round 0 allocate() took 1.689164secs to make 1000 offers
round 50 allocate() took 1.672373secs to make 1000 offers
round 100 allocate() took 1.680571secs to make 1000 offers
round 150 allocate() took 1.674683secs to make 1000 offers
round 199 allocate() took 1.671525secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6888us
Added 1000 agents in 2.096218secs
round 0 allocate() took 1.704491secs to make 1000 offers
round 50 allocate() took 1.718623secs to make 1000 offers
round 100 allocate() took 1.716224secs to make 1000 offers
round 150 allocate() took 1.707343secs to make 1000 offers
round 199 allocate() took 1.727467secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 7304us
Added 1000 agents in 2.071009secs
round 0 allocate() took 1.689045secs to make 1000 offers
round 50 allocate() took 1.691524secs to make 1000 offers
round 100 allocate() took 1.688873secs to make 1000 offers
round 150 allocate() took 1.688713secs to make 1000 offers
round 199 allocate() took 1.691223secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 10:01 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Refactor.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 1e0b9453ed0c4b2fa68f0258dcd6a597c33f2c14
src/tests/resources_utils.hpp 1f41f02babce5c8174ea2223f4dc7470452fbaf1
src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 10%) on runtime performance in allocations as compared to HEAD (without shared resources). Also, there is no visible impact in performance when shared resources are added in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6907us
Added 1000 agents in 2.057098secs
round 0 allocate() took 1.689164secs to make 1000 offers
round 50 allocate() took 1.672373secs to make 1000 offers
round 100 allocate() took 1.680571secs to make 1000 offers
round 150 allocate() took 1.674683secs to make 1000 offers
round 199 allocate() took 1.671525secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6888us
Added 1000 agents in 2.096218secs
round 0 allocate() took 1.704491secs to make 1000 offers
round 50 allocate() took 1.718623secs to make 1000 offers
round 100 allocate() took 1.716224secs to make 1000 offers
round 150 allocate() took 1.707343secs to make 1000 offers
round 199 allocate() took 1.727467secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 7304us
Added 1000 agents in 2.071009secs
round 0 allocate() took 1.689045secs to make 1000 offers
round 50 allocate() took 1.691524secs to make 1000 offers
round 100 allocate() took 1.688873secs to make 1000 offers
round 150 allocate() took 1.688713secs to make 1000 offers
round 199 allocate() took 1.691223secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 10:45 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased after batch allocation patch was merged.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 3ecedb8488b6bdcae9d326bf9c736eb96f056ce0
src/tests/resources_utils.hpp 18dcca7f171102df8fe88f10785f70c5d1cf5b32
src/tests/resources_utils.cpp be1feb97be552af582dbba3a54fa5fa0714b3eb2
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 10%) on runtime performance in allocations as compared to HEAD (without shared resources). Also, there is no visible impact in performance when shared resources are added in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6907us
Added 1000 agents in 2.057098secs
round 0 allocate() took 1.689164secs to make 1000 offers
round 50 allocate() took 1.672373secs to make 1000 offers
round 100 allocate() took 1.680571secs to make 1000 offers
round 150 allocate() took 1.674683secs to make 1000 offers
round 199 allocate() took 1.671525secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6888us
Added 1000 agents in 2.096218secs
round 0 allocate() took 1.704491secs to make 1000 offers
round 50 allocate() took 1.718623secs to make 1000 offers
round 100 allocate() took 1.716224secs to make 1000 offers
round 150 allocate() took 1.707343secs to make 1000 offers
round 199 allocate() took 1.727467secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 7304us
Added 1000 agents in 2.071009secs
round 0 allocate() took 1.689045secs to make 1000 offers
round 50 allocate() took 1.691524secs to make 1000 offers
round 100 allocate() took 1.688873secs to make 1000 offers
round 150 allocate() took 1.688713secs to make 1000 offers
round 199 allocate() took 1.691223secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 5:59 a.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp e04d1998679fcf022bb3741676a62da8b01ce97c
src/tests/resources_utils.hpp 18dcca7f171102df8fe88f10785f70c5d1cf5b32
src/tests/resources_utils.cpp be1feb97be552af582dbba3a54fa5fa0714b3eb2
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 10%) on runtime performance in allocations as compared to HEAD (without shared resources). Also, there is no visible impact in performance when shared resources are added in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6907us
Added 1000 agents in 2.057098secs
round 0 allocate() took 1.689164secs to make 1000 offers
round 50 allocate() took 1.672373secs to make 1000 offers
round 100 allocate() took 1.680571secs to make 1000 offers
round 150 allocate() took 1.674683secs to make 1000 offers
round 199 allocate() took 1.671525secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6888us
Added 1000 agents in 2.096218secs
round 0 allocate() took 1.704491secs to make 1000 offers
round 50 allocate() took 1.718623secs to make 1000 offers
round 100 allocate() took 1.716224secs to make 1000 offers
round 150 allocate() took 1.707343secs to make 1000 offers
round 199 allocate() took 1.727467secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 7304us
Added 1000 agents in 2.071009secs
round 0 allocate() took 1.689045secs to make 1000 offers
round 50 allocate() took 1.691524secs to make 1000 offers
round 100 allocate() took 1.688873secs to make 1000 offers
round 150 allocate() took 1.688713secs to make 1000 offers
round 199 allocate() took 1.691223secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review163220
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53096, 45962, 55359, 49571]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 26, 2017, 10:06 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 10:06 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-5771
> https://issues.apache.org/jira/browse/MESOS-5771
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allocations test has the following resource configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
> resources; and offers from every other alternate slave contains
> a shared resource.
>
> This test is parameterized based on number of agents, number of
> frameworks and resource configuration.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
> src/tests/resources_utils.hpp 18dcca7f171102df8fe88f10785f70c5d1cf5b32
> src/tests/resources_utils.cpp be1feb97be552af582dbba3a54fa5fa0714b3eb2
>
> Diff: https://reviews.apache.org/r/49571/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
> Allocations benchmark test results
> ==================================
> Support of shared resources has a small impact (roughly 10%) on runtime performance in allocations as compared to HEAD (without shared resources). Also, there is no visible impact in performance when shared resources are added in the tests.
>
> Following is a snapshot with 1000 agents and 200 frameworks.
>
> With the patch (and no shared resources)
> ----------------------------------------
> [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
> Using 1000 agents and 200 frameworks with resource type 0
> Added 200 frameworks in 6907us
> Added 1000 agents in 2.057098secs
> round 0 allocate() took 1.689164secs to make 1000 offers
> round 50 allocate() took 1.672373secs to make 1000 offers
> round 100 allocate() took 1.680571secs to make 1000 offers
> round 150 allocate() took 1.674683secs to make 1000 offers
> round 199 allocate() took 1.671525secs to make 1000 offers
>
> With the patch (and shared resources on all agents)
> ---------------------------------------------------
> [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
> Using 1000 agents and 200 frameworks with resource type 1
> Added 200 frameworks in 6888us
> Added 1000 agents in 2.096218secs
> round 0 allocate() took 1.704491secs to make 1000 offers
> round 50 allocate() took 1.718623secs to make 1000 offers
> round 100 allocate() took 1.716224secs to make 1000 offers
> round 150 allocate() took 1.707343secs to make 1000 offers
> round 199 allocate() took 1.727467secs to make 1000 offers
>
> With the patch (and shared resources on alternate agents)
> ---------------------------------------------------------
> [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
> Using 1000 agents and 200 frameworks with resource type 2
> Added 200 frameworks in 7304us
> Added 1000 agents in 2.071009secs
> round 0 allocate() took 1.689045secs to make 1000 offers
> round 50 allocate() took 1.691524secs to make 1000 offers
> round 100 allocate() took 1.688873secs to make 1000 offers
> round 150 allocate() took 1.688713secs to make 1000 offers
> round 199 allocate() took 1.691223secs to make 1000 offers
>
> Based on HEAD, with all regular resources (no shared resources in HEAD supported)
> ---------------------------------------------------------------------------------
> [ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
> Using 1000 agents and 200 frameworks with resource type 0
> Added 200 frameworks in 6801us
> Added 1000 agents in 1.721447secs
> round 0 allocate() took 1.502953secs to make 1000 offers
> round 50 allocate() took 1.520157secs to make 1000 offers
> round 100 allocate() took 1.517221secs to make 1000 offers
> round 150 allocate() took 1.526446secs to make 1000 offers
> round 199 allocate() took 1.538005secs to make 1000 offers
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 49571: Added a benchmark test for allocations.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 10:06 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
src/tests/resources_utils.hpp 18dcca7f171102df8fe88f10785f70c5d1cf5b32
src/tests/resources_utils.cpp be1feb97be552af582dbba3a54fa5fa0714b3eb2
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 10%) on runtime performance in allocations as compared to HEAD (without shared resources). Also, there is no visible impact in performance when shared resources are added in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6907us
Added 1000 agents in 2.057098secs
round 0 allocate() took 1.689164secs to make 1000 offers
round 50 allocate() took 1.672373secs to make 1000 offers
round 100 allocate() took 1.680571secs to make 1000 offers
round 150 allocate() took 1.674683secs to make 1000 offers
round 199 allocate() took 1.671525secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6888us
Added 1000 agents in 2.096218secs
round 0 allocate() took 1.704491secs to make 1000 offers
round 50 allocate() took 1.718623secs to make 1000 offers
round 100 allocate() took 1.716224secs to make 1000 offers
round 150 allocate() took 1.707343secs to make 1000 offers
round 199 allocate() took 1.727467secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 7304us
Added 1000 agents in 2.071009secs
round 0 allocate() took 1.689045secs to make 1000 offers
round 50 allocate() took 1.691524secs to make 1000 offers
round 100 allocate() took 1.688873secs to make 1000 offers
round 150 allocate() took 1.688713secs to make 1000 offers
round 199 allocate() took 1.691223secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha