You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mathewjacob1002 (via GitHub)" <gi...@apache.org> on 2023/07/26 00:00:54 UTC

[GitHub] [spark] mathewjacob1002 commented on a diff in pull request #42118: [SPARK-44264][WIP]E2E Testing for Deepspeed

mathewjacob1002 commented on code in PR #42118:
URL: https://github.com/apache/spark/pull/42118#discussion_r1274227715


##########
python/pyspark/ml/torch/distributor.py:
##########
@@ -918,6 +918,13 @@ def _create_save_dir(root_dir: Optional[str] = None) -> str:
     @staticmethod
     def _cleanup_files(save_dir: str) -> None:
         shutil.rmtree(save_dir, ignore_errors=True)
+    
+    @staticmethod
+    @contextmanager
+    def _setup_e2e_mocking_env():
+        TorchDistributor._E2E_MOCK = True
+        yield
+        TorchDistributor._E2E_MOCK = False

Review Comment:
   this is old code - will remove now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org