[GitHub] [incubator-eventmesh] slowpao commented on a diff in pull request #3322: [ISSUE #3309] add subscriber acl authentication

["slowpao (via GitHub)" <gi...@apache.org>]

slowpao commented on code in PR #3322:
URL: https://github.com/apache/incubator-eventmesh/pull/3322#discussion_r1123280426


##########
settings.gradle:
##########
@@ -66,4 +66,9 @@ include 'eventmesh-trace-plugin:eventmesh-trace-jaeger'
 include 'eventmesh-webhook'
 include 'eventmesh-webhook:eventmesh-webhook-api'
 include 'eventmesh-webhook:eventmesh-webhook-admin'
-include 'eventmesh-webhook:eventmesh-webhook-receive'
\ No newline at end of file
+include 'eventmesh-webhook:eventmesh-webhook-receive'
+include 'eventmesh-security-auth-token'
+include 'eventmesh-security-plugin:eventmesh-security-auth-token'
+findProject(':eventmesh-security-plugin:eventmesh-security-auth-token')?.name = 'eventmesh-security-auth-token'
+include 'eventmesh-security-plugin:eventmesh-security-acl-token'
+findProject(':eventmesh-security-plugin:eventmesh-security-acl-token')?.name = 'eventmesh-security-acl-token'

Review Comment:
   OK, I will fix it next time I submit



##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java:
##########
@@ -72,6 +72,8 @@ public class CommonConfiguration {
     @ConfigFiled(field = "connector.plugin.type", notEmpty = true)
     private String eventMeshConnectorPluginType = "rocketmq";
 
+    @ConfigFiled(field = "security.validation.type.token", notEmpty = true)
+    private boolean eventMeshSecurityValidateTypeToken = false;

Review Comment:
   OK, I will fix it next time I submit



##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java:
##########
@@ -95,6 +97,8 @@ public class CommonConfiguration {
     @ConfigFiled(field = "server.registry.enabled")
     private boolean eventMeshServerRegistryEnable = false;
 
+    @ConfigFiled(field = "security.publickey")
+    private String eventMeshSecurityPublickey = "";

Review Comment:
   OK, I will fix it next time I submit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org