You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/06 14:56:39 UTC

[GitHub] [arrow] paleolimbot commented on a change in pull request #11870: ARROW-14992 [R] Installation can't use prebuilt Arrow binaries on Pop! OS

paleolimbot commented on a change in pull request #11870:
URL: https://github.com/apache/arrow/pull/11870#discussion_r763082595



##########
File path: r/tools/nixlibs.R
##########
@@ -47,7 +47,7 @@ quietly <- !env_is("ARROW_R_DEV", "true")
 
 # Default is build from source, not download a binary
 build_ok <- !env_is("LIBARROW_BUILD", "false")
-binary_ok <- env_is("LIBARROW_BINARY", "true")
+binary_ok <- env_is("LIBARROW_BINARY", "true") || env_is("NOT_CRAN", "true")

Review comment:
       I think it used to be that and changed here: https://github.com/apache/arrow/commit/9aee5245fce9b5cf77c0f8ac4610790f1f8897e5#diff-935746c34b16289a07b0d9bf7642dbd268b18059b6187f7cdec7c464be47a3deL50
   
   (which is why I took this approach, assuming there was a good reason for the previous change)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org