You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "Pierre Smits (JIRA)" <ji...@apache.org> on 2018/12/13 17:03:00 UTC

[jira] [Reopened] (OFBIZ-3844) Splitting CommonRate and CommonProductRating

     [ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre Smits reopened OFBIZ-3844:
---------------------------------

This is not improving the issue, but rather replacing one confusing set with another.
 
It would be better to associate the product perception with rating or ratings, and keep the monetary aspect of price per time one with rate and rates.

> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
>                 Key: OFBIZ-3844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>    Affects Versions: Release 09.04
>         Environment: irrelevant, only XML and FTL changes
>            Reporter: Carsten Schinzer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: 0001-OFBIZ-3844_commonRate_and_commonRating.patch, 0002-OFBIZ-3844_commonRate_and_commonRating.patch, OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)