You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/19 13:54:26 UTC

[GitHub] [flink] matriv opened a new pull request, #19516: [FLINK-27212][table-planner] Revert binary<->string cast behaviour (backport)

matriv opened a new pull request, #19516:
URL: https://github.com/apache/flink/pull/19516

   ## What is the purpose of the change
   
   Revert behaviour of binary to string casts and vice versa, to not use
   hex enconding/decoding, but simple UTF-8 bytes transformation from a
   byte[] to a string and vice versa.
   
   Add a `isPrinting()` method to the `CastRule.Context` set to true used by `RowDataToStringConverterImpl`
   which defines a different casting behaviour for `BinaryToStringCastRule` when printing binary columns, so
   that we output columns of binary type as (for example): `x'ab03f98e'`, which can easily be copy pasted as
   a binary literal to another SQL query.
   
   ## Verifying this change
   
   Adjusted the tests accordingly in
   
     - `CastFunctionITCase`
     - `CastRulesTest`
     - `ScalarFunctionsTest`
     - `CastFunctionMiscITCase`
     - Added binary column to `CliTableauResultViewTest` to test the printing.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19516: [FLINK-27212][table-planner] Revert binary<->string cast behaviour (backport)

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19516:
URL: https://github.com/apache/flink/pull/19516#issuecomment-1102693497

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6890b40b17cdedbc9e729db08aeeb37063e1eef1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6890b40b17cdedbc9e729db08aeeb37063e1eef1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6890b40b17cdedbc9e729db08aeeb37063e1eef1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #19516: [FLINK-27212][table-planner] Revert binary<->string cast behaviour (backport)

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #19516: [FLINK-27212][table-planner] Revert binary<->string cast behaviour (backport)
URL: https://github.com/apache/flink/pull/19516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #19516: [FLINK-27212][table-planner] Revert binary<->string cast behaviour (backport)

Posted by GitBox <gi...@apache.org>.
twalthr commented on PR #19516:
URL: https://github.com/apache/flink/pull/19516#issuecomment-1102797296

   Fixed in 5f280f2eca4ad80ee981c44f114b549af5f5da71.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org