You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by nssalian <gi...@git.apache.org> on 2016/07/29 05:40:01 UTC

[GitHub] flink issue #2307: [FLINK-4269] Decrease log level in RuntimeMonitorHandler

Github user nssalian commented on the issue:

    https://github.com/apache/flink/pull/2307
  
    Hi @aditivin , welcome to the community. Thank you for the PR as well.
    A few suggestions:
    1) Upon opening a PR, it is best to add more information regarding testing or even checks that you have done.
    I believe the PR template helps add more information with regards to testing /checks.
    
    2) I don't see much testing that can be done here, anything you see that can help testing the debug logging, @aditivin?
    
    3) One additional point would be to enable the travis build on your repository.
     (As Flink comes with a travis.yml all you need to do is to go to Travis, login with your github user and hit enable on the repo.) A local build helps understand if there are issues that could occur. 
    This link should be helpful: https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---