You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jan Høydahl (Jira)" <ji...@apache.org> on 2022/01/18 09:27:00 UTC
[jira] [Commented] (SOLR-11946) Move bin/solr arg-parsing logic to Java
[ https://issues.apache.org/jira/browse/SOLR-11946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477699#comment-17477699 ]
Jan Høydahl commented on SOLR-11946:
------------------------------------
Closing this in favor of newer (mora active) SOLR-15831. Perhaps you [~gerlowskija] and [~thelabdude] should talk?
> Move bin/solr arg-parsing logic to Java
> ---------------------------------------
>
> Key: SOLR-11946
> URL: https://issues.apache.org/jira/browse/SOLR-11946
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 8.0
> Reporter: Jason Gerlowski
> Priority: Minor
> Fix For: 8.1, 9.0
>
> Attachments: SOLR-11946.patch
>
>
> Currently, there is logic in three different places that parses arguments for the {{bin/solr}} scripts. There is logic in the scripts themselves ({{bin/solr}}, {{bin/solr.cmd}}), and there is logic in Java to parse the arguments sent by the scripts themselves ({{SolrCLI.java}}.
> This creates maintenance burden. It makes it easy for inconsistencies/bugs to creep into the scripts (see SOLR-11840 and SOLR-11441, for a few examples). It adds work when adding/removing/modifying {{bin/solr}} script behavior. And it forces anyone hoping to improve the scripts to be conversant in both bash and Windows batch scripting.
> It would be a big help if _all_ the argument parsing was done on the Java side, and little or none was done in the scripts themselves. There are a few situations in which this is difficult, but in no cases is it impossible.
> We should move this logic into Java-land.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org