You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/18 14:21:29 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #2334: CONTRIBUTING.md: talk about preferred commit message format

v01d opened a new pull request #2334:
URL: https://github.com/apache/incubator-nuttx/pull/2334


   ## Summary
   
   Mention the preferred commit message as "<keyword>: <message>"
   
   ## Impact
   
   Contributing document
   
   ## Testing
   
   N/A
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 merged pull request #2334: CONTRIBUTING.md: talk about preferred commit message format

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #2334:
URL: https://github.com/apache/incubator-nuttx/pull/2334


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2334: CONTRIBUTING.md: talk about preferred commit message format

Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #2334:
URL: https://github.com/apache/incubator-nuttx/pull/2334#discussion_r526309282



##########
File path: CONTRIBUTING.md
##########
@@ -14,6 +14,11 @@ it is very important you follow these guidelines:
         <first line (up to ~80 characters)>
 
         <more paragraphs here>
+        
+    * The first line should have a prefix to give context
+      (unless context is really clear), such as:
+      
+          <keyword>: <message>

Review comment:
       I aggree




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2334: CONTRIBUTING.md: talk about preferred commit message format

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #2334:
URL: https://github.com/apache/incubator-nuttx/pull/2334#discussion_r526307364



##########
File path: CONTRIBUTING.md
##########
@@ -14,6 +14,11 @@ it is very important you follow these guidelines:
         <first line (up to ~80 characters)>
 
         <more paragraphs here>
+        
+    * The first line should have a prefix to give context
+      (unless context is really clear), such as:
+      
+          <keyword>: <message>

Review comment:
       ```suggestion
             <keyword>: <message>
             i.e sched: Fixed compiler warning
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org