You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/08 06:21:45 UTC
[GitHub] [kafka] chia7712 opened a new pull request #9712: KAFKA-10822 Force some stdout from downgrade_test.py for Travis
chia7712 opened a new pull request #9712:
URL: https://github.com/apache/kafka/pull/9712
downgrade_test.py does upgrade/downgrade for each tests. the upgrade/downgrade tasks take 10+ mins in Travis env so we ought to print something in order to avoid timeout caused by Travis.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9712:
URL: https://github.com/apache/kafka/pull/9712#discussion_r551751195
##########
File path: tests/kafkatest/tests/core/downgrade_test.py
##########
@@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security_protoc
self.setup_services(kafka_version, compression_types, security_protocol, static_membership)
self.await_startup()
- self.logger.info("First pass bounce - rolling upgrade")
+ print("First pass bounce - rolling upgrade", flush=True) # Force some stdout for Travis
Review comment:
https://github.com/confluentinc/ducktape/issues/260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9712:
URL: https://github.com/apache/kafka/pull/9712#discussion_r551704491
##########
File path: tests/kafkatest/tests/core/downgrade_test.py
##########
@@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security_protoc
self.setup_services(kafka_version, compression_types, security_protocol, static_membership)
self.await_startup()
- self.logger.info("First pass bounce - rolling upgrade")
+ print("First pass bounce - rolling upgrade", flush=True) # Force some stdout for Travis
Review comment:
I tried to configure ```ducktape``` to force more output but ```ducktape``` supports only ```--debug```. It is too noisy to me.
Another way is to make a patch for ```ducktape``` for INFO level support. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9712:
URL: https://github.com/apache/kafka/pull/9712#discussion_r551480985
##########
File path: tests/kafkatest/tests/core/downgrade_test.py
##########
@@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security_protoc
self.setup_services(kafka_version, compression_types, security_protocol, static_membership)
self.await_startup()
- self.logger.info("First pass bounce - rolling upgrade")
+ print("First pass bounce - rolling upgrade", flush=True) # Force some stdout for Travis
Review comment:
This seems weird. If we want to force stdout, we should configure the logged to do so, right?
##########
File path: tests/kafkatest/tests/core/downgrade_test.py
##########
@@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security_protoc
self.setup_services(kafka_version, compression_types, security_protocol, static_membership)
self.await_startup()
- self.logger.info("First pass bounce - rolling upgrade")
+ print("First pass bounce - rolling upgrade", flush=True) # Force some stdout for Travis
Review comment:
This seems weird. If we want to force stdout, we should configure the logger to do so, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9712:
URL: https://github.com/apache/kafka/pull/9712#discussion_r551719004
##########
File path: tests/kafkatest/tests/core/downgrade_test.py
##########
@@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security_protoc
self.setup_services(kafka_version, compression_types, security_protocol, static_membership)
self.await_startup()
- self.logger.info("First pass bounce - rolling upgrade")
+ print("First pass bounce - rolling upgrade", flush=True) # Force some stdout for Travis
Review comment:
That sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 closed pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis
Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #9712:
URL: https://github.com/apache/kafka/pull/9712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9712:
URL: https://github.com/apache/kafka/pull/9712#discussion_r551704491
##########
File path: tests/kafkatest/tests/core/downgrade_test.py
##########
@@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security_protoc
self.setup_services(kafka_version, compression_types, security_protocol, static_membership)
self.await_startup()
- self.logger.info("First pass bounce - rolling upgrade")
+ print("First pass bounce - rolling upgrade", flush=True) # Force some stdout for Travis
Review comment:
I tried to configure ```ducktape``` to force more output but ```ducktape``` supports only ```--debug```. It is too noisy to me.
Another way is to make a patch to ```ducktape``` for INFO level support. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9712:
URL: https://github.com/apache/kafka/pull/9712#issuecomment-753982409
The timeout of "no output" is caused by only ```replica_scale_test.py```. will go back here if #9797 get merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9712: KAFKA-10822 Force some stdout from downgrade_test.py/upgrade_test.py for Travis
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9712:
URL: https://github.com/apache/kafka/pull/9712#issuecomment-748409302
> Looks like the build is still in error?
Thanks for your reviews. The main purpose of this PR is to avoid timeout from downgrade_test.py/upgrade_test.py. I browse the test results and the timeout does not happen on downgrade_test.py/upgrade_test.py again. After fixing the timeout issue, I will go back to dead with the true failure of system tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org