You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/19 09:11:22 UTC
[GitHub] [hadoop-ozone] linyiqun opened a new pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
linyiqun opened a new pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
URL: https://github.com/apache/hadoop-ozone/pull/461
…tion message.
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## What is the link to the Apache JIRA
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
Posted by GitBox <gi...@apache.org>.
elek closed pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
URL: https://github.com/apache/hadoop-ozone/pull/461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
Posted by GitBox <gi...@apache.org>.
linyiqun commented on a change in pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
URL: https://github.com/apache/hadoop-ozone/pull/461#discussion_r368351064
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -335,7 +335,9 @@ private OzoneManager(OzoneConfiguration conf) throws IOException,
OZONE_OM_USER_MAX_VOLUME + " value should be greater than zero");
if (omStorage.getState() != StorageState.INITIALIZED) {
- throw new OMException("OM not initialized.",
+ throw new OMException("OM not initialized, current OM storage state: " +
+ omStorage.getState().name() + ". Please check if 'ozone om --init' "
Review comment:
Thanks @xiaoyuyao for the review. Have addressed the comment now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
URL: https://github.com/apache/hadoop-ozone/pull/461#discussion_r368341657
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -335,7 +335,9 @@ private OzoneManager(OzoneConfiguration conf) throws IOException,
OZONE_OM_USER_MAX_VOLUME + " value should be greater than zero");
if (omStorage.getState() != StorageState.INITIALIZED) {
- throw new OMException("OM not initialized.",
+ throw new OMException("OM not initialized, current OM storage state: " +
+ omStorage.getState().name() + ". Please check if 'ozone om --init' "
Review comment:
Can we rephrase "Please check if 'ozone om --init' command is executed before starting the OM service.",
Please ensure 'ozone om --init' command is executed once before starting the OM service.",
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] linyiqun commented on issue #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
Posted by GitBox <gi...@apache.org>.
linyiqun commented on issue #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
URL: https://github.com/apache/hadoop-ozone/pull/461#issuecomment-576260661
Thanks for the review and merge, @elek !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #461: HDDS-2910. OzoneManager startup failure with throwing unhelpful excep…
URL: https://github.com/apache/hadoop-ozone/pull/461#discussion_r368341657
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -335,7 +335,9 @@ private OzoneManager(OzoneConfiguration conf) throws IOException,
OZONE_OM_USER_MAX_VOLUME + " value should be greater than zero");
if (omStorage.getState() != StorageState.INITIALIZED) {
- throw new OMException("OM not initialized.",
+ throw new OMException("OM not initialized, current OM storage state: " +
+ omStorage.getState().name() + ". Please check if 'ozone om --init' "
Review comment:
Thanks @linyiqun for the improvement.
Can we rephrase "Please check if 'ozone om --init' command is executed before starting the OM service." to
Please ensure 'ozone om --init' command is executed once before starting the OM service.",
Otherwise, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org