You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/01/23 13:46:55 UTC

[GitHub] wu-sheng opened a new pull request #2198: Optimize the agent grpc channel management.

wu-sheng opened a new pull request #2198: Optimize the agent grpc channel management.
URL: https://github.com/apache/incubator-skywalking/pull/2198
 
 
   From the #2190 , when re-select and reconnect happens, there is possible to leak memory and grpc client stub. In this pull request, I am making this adjustment.
   1. Only reconnect when re-select got another network address. 
   1. We still suggest to use load balance between agent and collector cluster, also because of this and (1), reconnect wouldn't be controlled by agent client even. gRPC client supports reconnect to the same target address already. See the `GRPCChannelManagerTest`(not active in default, considering about travis-CI performance)
   1. Close the channel if new one selected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services