You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/09/25 21:45:06 UTC
[Impala-ASF-CR] IMPALA-11917: Fix clang-analyzer-unix.Stream
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24959
Change subject: IMPALA-11917: Fix clang-analyzer-unix.Stream
......................................................................
IMPALA-11917: Fix clang-analyzer-unix.Stream
Manage FILE streams with RAII so failed opens and early assertion
returns cannot dereference or leak stream resources.
Change-Id: I201e5735e3a434cac8934a73bf3d7f9c11556ad7
Assisted-by: GPT-5.6-Sol (GitHub Copilot)
---
M .clang-tidy
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/util/parquet-reader.cc
3 files changed, 21 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/24959/1
--
To view, visit http://gerrit.cloudera.org:8080/24959
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I201e5735e3a434cac8934a73bf3d7f9c11556ad7
Gerrit-Change-Number: 24959
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11917: Fix clang-analyzer-unix.Stream
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24959 )
Change subject: IMPALA-11917: Fix clang-analyzer-unix.Stream
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/24205/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24959
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201e5735e3a434cac8934a73bf3d7f9c11556ad7
Gerrit-Change-Number: 24959
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Sep 2026 22:35:06 +0000
Gerrit-HasComments: No