svn commit: r1421901 - /subversion/trunk/subversion/libsvn_subr/error.c

[ph...@apache.org]

Author: philip
Date: Fri Dec 14 14:39:11 2012
New Revision: 1421901

URL: http://svn.apache.org/viewvc?rev=1421901&view=rev
Log:
Revert part of r1421668.

* subversion/libsvn_subr/error.c
  (svn_error__is_tracing_link): Use a strcmp as comparing pointers
   doesn't work when the error is sent over the network.

Modified:
    subversion/trunk/subversion/libsvn_subr/error.c

Modified: subversion/trunk/subversion/libsvn_subr/error.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/error.c?rev=1421901&r1=1421900&r2=1421901&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/error.c (original)
+++ subversion/trunk/subversion/libsvn_subr/error.c Fri Dec 14 14:39:11 2012
@@ -384,7 +384,11 @@ svn_boolean_t
 svn_error__is_tracing_link(svn_error_t *err)
 {
 #ifdef SVN_ERR__TRACING
-  return (err && err->message == error_tracing_link);
+  /* ### A strcmp()?  Really?  I think it's the best we can do unless
+     ### we add a boolean field to svn_error_t that's set only for
+     ### these "placeholder error chain" items.  Not such a bad idea,
+     ### really...  */
+  return (err && err->message && !strcmp(err->message, error_tracing_link));
 #else
   return FALSE;
 #endif