You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/03 16:57:06 UTC

[GitHub] [geode] jujoramos commented on pull request #4848: GEODE-7670: Add Tests for PR clear

jujoramos commented on pull request #4848:
URL: https://github.com/apache/geode/pull/4848#issuecomment-653622985


   @agingade 
   
   I've updated the `PR` with the changes you suggested (add `bucketRegion.lockRVVForBulkOp()` and `bucketRegion.unlockRVVForBulkOp()` to `PutAllPRMessage.doLocalPutAll`). I've also modified the test to correctly compare the RVVs from the buckets.
   I'm still seeing some random failures when comparing (primary vs secondary) the `values` and `versions` stored within the `Bucket`, specially whenever the `clear` is executed concurrently with `putAll`.
   That said, I'd suggest to move your suggestions (`bucketRegion.lockRVVForBulkOp()` and `bucketRegion.unlockRVVForBulkOp()`) to a new ticket and only use this `PR` for the actual distributed test.
   Please let me know what you think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org