You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/12 17:34:56 UTC
[GitHub] [druid] jihoonson opened a new pull request #11243: Fix taskQueue to honor
jihoonson opened a new pull request #11243:
URL: https://github.com/apache/druid/pull/11243
### Description
`useLineageBasedSegmentAllocation` in default taskContext is always overridden currently.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 merged pull request #11243: Fix taskQueue to respect useLineageBasedSegmentAllocation in default taskContext
Posted by GitBox <gi...@apache.org>.
asdf2014 merged pull request #11243:
URL: https://github.com/apache/druid/pull/11243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] capistrant commented on pull request #11243: Fix taskQueue to respect useLineageBasedSegmentAllocation in default taskContext
Posted by GitBox <gi...@apache.org>.
capistrant commented on pull request #11243:
URL: https://github.com/apache/druid/pull/11243#issuecomment-840655972
> @capistrant yes, because it can be useful for the replacing rolling downgrade. In the replacing rolling downgrade, you can terminate nodes one at a time and add a new node that replaces with the terminated one. Suppose you have your cluster upgraded and a task running that uses the new segment allocation protocol. But a new critical bug is found in the new version and now you want to downgrade your cluster. In this case, you first need to wait until there is no running task that uses the new protocol before you start the downgrade process because every task must use the legacy protocol during the downgrade. To do this, you will need to either downgrade the overlord first or set `useLineageBasedSegmentAllocation` to false in the default taskContext. If you cannot downgrade the overlord first for some reason, you should be able to set it to false.
thanks for the explainer! LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] capistrant edited a comment on pull request #11243: Fix taskQueue to respect useLineageBasedSegmentAllocation in default taskContext
Posted by GitBox <gi...@apache.org>.
capistrant edited a comment on pull request #11243:
URL: https://github.com/apache/druid/pull/11243#issuecomment-840123149
I'm catching up on the initial PR before this still. I think I understand what this PR is doing and it looks good to me. but as your comment says that there is a critical bug in the legacy way of doing this, do we really want to allow the override of the new value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] capistrant commented on pull request #11243: Fix taskQueue to respect useLineageBasedSegmentAllocation in default taskContext
Posted by GitBox <gi...@apache.org>.
capistrant commented on pull request #11243:
URL: https://github.com/apache/druid/pull/11243#issuecomment-840123149
I'm catching up on the initial PR for this still. I understand what this PR is doing and it looks good to me. but as your comment says that there is a critical bug in the legacy way of doing this, do we really want to allow the override of the new value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] capistrant edited a comment on pull request #11243: Fix taskQueue to respect useLineageBasedSegmentAllocation in default taskContext
Posted by GitBox <gi...@apache.org>.
capistrant edited a comment on pull request #11243:
URL: https://github.com/apache/druid/pull/11243#issuecomment-840123149
I'm catching up on the initial PR before this still. I think I understand what this PR is doing and it looks good to me. but as your comment in SinglePhaseParallelIndexTaskRunner says that there is a critical bug in the legacy way of doing this, do we really want to allow the override of the new value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #11243: Fix taskQueue to respect useLineageBasedSegmentAllocation in default taskContext
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #11243:
URL: https://github.com/apache/druid/pull/11243#issuecomment-840128738
@capistrant yes, because it can be useful for the replacing rolling downgrade. In the replacing rolling downgrade, you can terminate nodes one at a time and add a new node that replaces with the terminated one. Suppose you have your cluster upgraded and a task running that uses the new segment allocation protocol. But a new critical bug is found in the new version and now you want to downgrade your cluster. In this case, you first need to wait until there is no running task that uses the new protocol before you start the downgrade process because every task must use the legacy protocol during the downgrade. To do this, you will need to either downgrade the overlord first or set `useLineageBasedSegmentAllocation` to false in the default taskContext. If you cannot downgrade the overlord first for some reason, you should be able to set it to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org