You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Filip Maj (JIRA)" <ji...@apache.org> on 2012/09/17 22:51:07 UTC

[jira] [Created] (CB-1486) RAT audit in iOS

Filip Maj created CB-1486:
-----------------------------

             Summary: RAT audit in iOS
                 Key: CB-1486
                 URL: https://issues.apache.org/jira/browse/CB-1486
             Project: Apache Cordova
          Issue Type: Sub-task
          Components: iOS
            Reporter: Filip Maj
            Assignee: Steve Gill


./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.h
  ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.m
  ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.h
  ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.m
  ./incubator-cordova-ios/CordovaLib/Classes/debugview/WebScriptDebugDelegate.h
./incubator-cordova-ios/bin/diagnose_project
  ./incubator-cordova-ios/bin/update_cordova_subproject

need apache source headers

http://www.apache.org/legal/src-headers.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1486) RAT audit in iOS

Posted by "Steve Gill (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457360#comment-13457360 ] 

Steve Gill commented on CB-1486:
--------------------------------

Thanks Shaz. How does the Apple license and the license by Matt Gallagher work in relation to the Notice file? 

According to http://www.apache.org/legal/src-headers.html
If the source file is submitted with a copyright notice included in it, the copyright owner (or owner's agent) must either:
-remove such notices, or
-move them to the NOTICE file associated with each applicable project release, or
-provide written permission for the ASF to make such removal or relocation of the notices.

p.s. adding headers to python script

                
> RAT audit in iOS
> ----------------
>
>                 Key: CB-1486
>                 URL: https://issues.apache.org/jira/browse/CB-1486
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Filip Maj
>            Assignee: Steve Gill
>
> ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.h
>   ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.m
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.h
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.m
>   ./incubator-cordova-ios/CordovaLib/Classes/debugview/WebScriptDebugDelegate.h
> ./incubator-cordova-ios/bin/diagnose_project
>   ./incubator-cordova-ios/bin/update_cordova_subproject
> need apache source headers
> http://www.apache.org/legal/src-headers.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1486) RAT audit in iOS

Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457354#comment-13457354 ] 

Shazron Abdullah commented on CB-1486:
--------------------------------------

See CB-788 regarding CDVReachability license (it's ok, BSD equivalent). Since WebScriptDebugDelegate.h has the same license, it applies as well.

NSData+Base64 stuff as Steve mentioned is allowed, here's the license: http://cocoawithlove.com/p/about.html

The only two items that need to add Apache source headers are the two python scripts referenced above in the bin subfolder.
                
> RAT audit in iOS
> ----------------
>
>                 Key: CB-1486
>                 URL: https://issues.apache.org/jira/browse/CB-1486
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Filip Maj
>            Assignee: Steve Gill
>
> ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.h
>   ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.m
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.h
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.m
>   ./incubator-cordova-ios/CordovaLib/Classes/debugview/WebScriptDebugDelegate.h
> ./incubator-cordova-ios/bin/diagnose_project
>   ./incubator-cordova-ios/bin/update_cordova_subproject
> need apache source headers
> http://www.apache.org/legal/src-headers.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1486) RAT audit in iOS

Posted by "Shazron Abdullah (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457385#comment-13457385 ] 

Shazron Abdullah commented on CB-1486:
--------------------------------------

Hmm not sure about this, although the copyrights are already in the LICENSE file.
                
> RAT audit in iOS
> ----------------
>
>                 Key: CB-1486
>                 URL: https://issues.apache.org/jira/browse/CB-1486
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Filip Maj
>            Assignee: Steve Gill
>
> ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.h
>   ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.m
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.h
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.m
>   ./incubator-cordova-ios/CordovaLib/Classes/debugview/WebScriptDebugDelegate.h
> ./incubator-cordova-ios/bin/diagnose_project
>   ./incubator-cordova-ios/bin/update_cordova_subproject
> need apache source headers
> http://www.apache.org/legal/src-headers.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1486) RAT audit in iOS

Posted by "Steve Gill (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457393#comment-13457393 ] 

Steve Gill commented on CB-1486:
--------------------------------

I'm going to close this for now. If we have issues with notice file stuff, we can figure it out then.
                
> RAT audit in iOS
> ----------------
>
>                 Key: CB-1486
>                 URL: https://issues.apache.org/jira/browse/CB-1486
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Filip Maj
>            Assignee: Steve Gill
>             Fix For: 2.2.0
>
>
> ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.h
>   ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.m
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.h
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.m
>   ./incubator-cordova-ios/CordovaLib/Classes/debugview/WebScriptDebugDelegate.h
> ./incubator-cordova-ios/bin/diagnose_project
>   ./incubator-cordova-ios/bin/update_cordova_subproject
> need apache source headers
> http://www.apache.org/legal/src-headers.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CB-1486) RAT audit in iOS

Posted by "Steve Gill (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Gill resolved CB-1486.
----------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.0
    
> RAT audit in iOS
> ----------------
>
>                 Key: CB-1486
>                 URL: https://issues.apache.org/jira/browse/CB-1486
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Filip Maj
>            Assignee: Steve Gill
>             Fix For: 2.2.0
>
>
> ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.h
>   ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.m
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.h
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.m
>   ./incubator-cordova-ios/CordovaLib/Classes/debugview/WebScriptDebugDelegate.h
> ./incubator-cordova-ios/bin/diagnose_project
>   ./incubator-cordova-ios/bin/update_cordova_subproject
> need apache source headers
> http://www.apache.org/legal/src-headers.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1486) RAT audit in iOS

Posted by "Steve Gill (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457345#comment-13457345 ] 

Steve Gill commented on CB-1486:
--------------------------------

CDVReachability.h and .m are licensed by Apple already.
NSData code is licensed to Matt Gallagher but he gives permission to use it.
WebScriptDebugDelegate.h is licensed by Apple.
Last two are python scripts.
                
> RAT audit in iOS
> ----------------
>
>                 Key: CB-1486
>                 URL: https://issues.apache.org/jira/browse/CB-1486
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: iOS
>            Reporter: Filip Maj
>            Assignee: Steve Gill
>
> ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.h
>   ./incubator-cordova-ios/CordovaLib/Classes/CDVReachability.m
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.h
>   ./incubator-cordova-ios/CordovaLib/Classes/NSData+Base64.m
>   ./incubator-cordova-ios/CordovaLib/Classes/debugview/WebScriptDebugDelegate.h
> ./incubator-cordova-ios/bin/diagnose_project
>   ./incubator-cordova-ios/bin/update_cordova_subproject
> need apache source headers
> http://www.apache.org/legal/src-headers.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira