You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/18 02:16:04 UTC

[GitHub] [incubator-seatunnel] Carl-Zhou-CN opened a new pull request, #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Carl-Zhou-CN opened a new pull request, #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   
   close #2958 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r1005465298


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -66,26 +73,45 @@ public class KafkaSourceSplitEnumerator implements SourceSplitEnumerator<KafkaSo
         this(metadata, context);
     }
 
+    KafkaSourceSplitEnumerator(ConsumerMetadata metadata, Context<KafkaSourceSplit> context,
+                               long discoveryIntervalMillis) {
+        this(metadata, context);
+        this.discoveryIntervalMillis = discoveryIntervalMillis;
+    }
+
     @Override
     public void open() {
         this.adminClient = initAdminClient(this.metadata.getProperties());
+        if (discoveryIntervalMillis > 0) {
+            this.executor = Executors.newScheduledThreadPool(1);

Review Comment:
   Please custom thread name, do not use default name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r1006305474


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -66,26 +73,45 @@ public class KafkaSourceSplitEnumerator implements SourceSplitEnumerator<KafkaSo
         this(metadata, context);
     }
 
+    KafkaSourceSplitEnumerator(ConsumerMetadata metadata, Context<KafkaSourceSplit> context,
+                               long discoveryIntervalMillis) {
+        this(metadata, context);
+        this.discoveryIntervalMillis = discoveryIntervalMillis;
+    }
+
     @Override
     public void open() {
         this.adminClient = initAdminClient(this.metadata.getProperties());
+        if (discoveryIntervalMillis > 0) {
+            this.executor = Executors.newScheduledThreadPool(1);

Review Comment:
   OK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r1005539753


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -66,26 +73,45 @@ public class KafkaSourceSplitEnumerator implements SourceSplitEnumerator<KafkaSo
         this(metadata, context);
     }
 
+    KafkaSourceSplitEnumerator(ConsumerMetadata metadata, Context<KafkaSourceSplit> context,
+                               long discoveryIntervalMillis) {
+        this(metadata, context);
+        this.discoveryIntervalMillis = discoveryIntervalMillis;
+    }
+
     @Override
     public void open() {
         this.adminClient = initAdminClient(this.metadata.getProperties());
+        if (discoveryIntervalMillis > 0) {
+            this.executor = Executors.newScheduledThreadPool(1);

Review Comment:
   Ok, I will add e2e tests later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r1011225258


##########
docs/en/connector-v2/source/kafka.md:
##########
@@ -49,6 +50,10 @@ If `pattern` is set to `true`,the regular expression for a pattern of topic name
 
 If true the consumer's offset will be periodically committed in the background.
 
+## partition-discovery.interval-millis [long]
+
+The interval for dynamically discovering topics and partitions.
+

Review Comment:
   OK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] EricJoy2048 closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
EricJoy2048 closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#issuecomment-1292898589

   > Retry CI after #3183 merged
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r1016459541


##########
docs/en/connector-v2/source/kafka.md:
##########
@@ -112,3 +117,7 @@ source {
 ### 2.3.0-beta 2022-10-20
 
 - Add Kafka Source Connector
+
+### next version
+
+- [Improve] Support for dynamic discover topic & partition in streaming mode [3125](https://github.com/apache/incubator-seatunnel/pull/3125)

Review Comment:
   ```suggestion
   - [Improve] Support for dynamic discover topic & partition in streaming mode ([3125](https://github.com/apache/incubator-seatunnel/pull/3125))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Hisoka-X closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r997677912


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -66,13 +69,42 @@ public class KafkaSourceSplitEnumerator implements SourceSplitEnumerator<KafkaSo
         this(metadata, context);
     }
 
+    KafkaSourceSplitEnumerator(ConsumerMetadata metadata, Context<KafkaSourceSplit> context,
+                               long discoveryIntervalMillis) {
+        this(metadata, context);
+        this.discoveryIntervalMillis = discoveryIntervalMillis;
+    }
+
     @Override
     public void open() {
         this.adminClient = initAdminClient(this.metadata.getProperties());
+        ParallelSource parallelSource = context.getParallelSource();

Review Comment:
   @Hisoka-X Well, I have this idea. I think that if the search thread fails, the consumer thread can be ended. If the search thread fails, do we need to affect the consumer thread



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r997673454


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -66,13 +69,42 @@ public class KafkaSourceSplitEnumerator implements SourceSplitEnumerator<KafkaSo
         this(metadata, context);
     }
 
+    KafkaSourceSplitEnumerator(ConsumerMetadata metadata, Context<KafkaSourceSplit> context,
+                               long discoveryIntervalMillis) {
+        this(metadata, context);
+        this.discoveryIntervalMillis = discoveryIntervalMillis;
+    }
+
     @Override
     public void open() {
         this.adminClient = initAdminClient(this.metadata.getProperties());
+        ParallelSource parallelSource = context.getParallelSource();

Review Comment:
   It's not right the connector to use translation module class. You can use `ScheduledThreadPoolExecutor` to execute topic find with fixed rate. Then close `ScheduledThreadPoolExecutor` when `KafkaSourceSplitEnumerator`  closed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#issuecomment-1292877933

   Retry CI after #3183 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#issuecomment-1291776792

   @Hisoka-X 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#issuecomment-1308354523

   @Hisoka-X @EricJoy2048 Please help to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r997678922


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -66,13 +69,42 @@ public class KafkaSourceSplitEnumerator implements SourceSplitEnumerator<KafkaSo
         this(metadata, context);
     }
 
+    KafkaSourceSplitEnumerator(ConsumerMetadata metadata, Context<KafkaSourceSplit> context,
+                               long discoveryIntervalMillis) {
+        this(metadata, context);
+        this.discoveryIntervalMillis = discoveryIntervalMillis;
+    }
+
     @Override
     public void open() {
         this.adminClient = initAdminClient(this.metadata.getProperties());
+        ParallelSource parallelSource = context.getParallelSource();

Review Comment:
   It should be, if not, user will think program running fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r997684338


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:
##########
@@ -66,13 +69,42 @@ public class KafkaSourceSplitEnumerator implements SourceSplitEnumerator<KafkaSo
         this(metadata, context);
     }
 
+    KafkaSourceSplitEnumerator(ConsumerMetadata metadata, Context<KafkaSourceSplit> context,
+                               long discoveryIntervalMillis) {
+        this(metadata, context);
+        this.discoveryIntervalMillis = discoveryIntervalMillis;
+    }
+
     @Override
     public void open() {
         this.adminClient = initAdminClient(this.metadata.getProperties());
+        ParallelSource parallelSource = context.getParallelSource();

Review Comment:
   The problem I'm facing now is that if I want to stop the source, it seems that I can only interrupt at pollNext,Because I can't get too much valid information in context,Do you have any other good suggestions,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Hisoka-X closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#discussion_r1010137062


##########
docs/en/connector-v2/source/kafka.md:
##########
@@ -49,6 +50,10 @@ If `pattern` is set to `true`,the regular expression for a pattern of topic name
 
 If true the consumer's offset will be periodically committed in the background.
 
+## partition-discovery.interval-millis [long]
+
+The interval for dynamically discovering topics and partitions.
+

Review Comment:
   Please add `changed log` reference https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Redis.md#next-version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3125:
URL: https://github.com/apache/incubator-seatunnel/pull/3125#issuecomment-1308117859

   @Carl-Zhou-CN Please resolve conflict. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] ic4y closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
ic4y closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode

Posted by GitBox <gi...@apache.org>.
Carl-Zhou-CN closed pull request #3125: [Improve][Connector-V2-kafka] Support for dynamic discover topic & partition in streaming mode
URL: https://github.com/apache/incubator-seatunnel/pull/3125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org