[GitHub] spark pull request: [SPARK-6324] [core] Centralize handling of scr...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/5841#issuecomment-107996878
  
    Ok, last patch LGTM. I wonder if it's worth it to add `KILLED` to the condition here: https://github.com/apache/spark/blob/master/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala#L122
    
    Even if YARN kills the app after a little while, there's a little bit of time for it to try to do a cleanup (in case the launcher is not around anymore).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org