You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ca...@apache.org on 2013/05/01 19:25:03 UTC
[1/6] git commit: [flex-asjs] - SimpleBinding must use flash.Events
on the AS side for click and other mouse events
Updated Branches:
refs/heads/feature/createjs-checkbox a898de058 -> 671e059ea
SimpleBinding must use flash.Events on the AS side for click and other mouse events
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/05632ae9
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/05632ae9
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/05632ae9
Branch: refs/heads/feature/createjs-checkbox
Commit: 05632ae947411f0c47770c0be99497a9447d3697
Parents: 128e84c
Author: Alex Harui <ah...@apache.org>
Authored: Tue Apr 30 07:41:15 2013 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Tue Apr 30 07:41:15 2013 -0700
----------------------------------------------------------------------
.../src/org/apache/flex/binding/SimpleBinding.as | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/05632ae9/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
----------------------------------------------------------------------
diff --git a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
index c5bd392..6e5a72a 100644
--- a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
+++ b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
@@ -18,11 +18,12 @@
////////////////////////////////////////////////////////////////////////////////
package org.apache.flex.binding
{
+ import flash.events.IEventDispatcher;
+ import flash.events.Event;
+
import org.apache.flex.core.IBead;
import org.apache.flex.core.IStrand;
import org.apache.flex.core.IDocument;
- import org.apache.flex.events.Event;
- import org.apache.flex.events.IEventDispatcher;
public class SimpleBinding implements IBead, IDocument
{
[4/6] git commit: [flex-asjs] - Selection Model should send
selectedIndexChanged as well when selectedItem changed
Posted by ca...@apache.org.
Selection Model should send selectedIndexChanged as well when selectedItem changed
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/cc79edbe
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/cc79edbe
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/cc79edbe
Branch: refs/heads/feature/createjs-checkbox
Commit: cc79edbed710ac39615ff4600325b8ce690e9748
Parents: fe54045
Author: Alex Harui <ah...@apache.org>
Authored: Tue Apr 30 07:43:15 2013 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Tue Apr 30 07:43:15 2013 -0700
----------------------------------------------------------------------
.../beads/models/ArraySelectionModel.as | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/cc79edbe/frameworks/as/src/org/apache/flex/html/staticControls/beads/models/ArraySelectionModel.as
----------------------------------------------------------------------
diff --git a/frameworks/as/src/org/apache/flex/html/staticControls/beads/models/ArraySelectionModel.as b/frameworks/as/src/org/apache/flex/html/staticControls/beads/models/ArraySelectionModel.as
index 600f84e..1e1aade 100644
--- a/frameworks/as/src/org/apache/flex/html/staticControls/beads/models/ArraySelectionModel.as
+++ b/frameworks/as/src/org/apache/flex/html/staticControls/beads/models/ArraySelectionModel.as
@@ -87,6 +87,7 @@ package org.apache.flex.html.staticControls.beads.models
}
}
dispatchEvent(new Event("selectedItemChanged"));
+ dispatchEvent(new Event("selectedIndexChanged"));
}
}
}
\ No newline at end of file
[3/6] git commit: [flex-asjs] - add initComplete event sort of like
creationComplete in current Flex SDK
Posted by ca...@apache.org.
add initComplete event sort of like creationComplete in current Flex SDK
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/fe54045f
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/fe54045f
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/fe54045f
Branch: refs/heads/feature/createjs-checkbox
Commit: fe54045f9ea16b9846f47985312375edd920ea6e
Parents: 81a2aab
Author: Alex Harui <ah...@apache.org>
Authored: Tue Apr 30 07:42:43 2013 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Tue Apr 30 07:42:43 2013 -0700
----------------------------------------------------------------------
frameworks/as/src/org/apache/flex/core/ViewBase.as | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/fe54045f/frameworks/as/src/org/apache/flex/core/ViewBase.as
----------------------------------------------------------------------
diff --git a/frameworks/as/src/org/apache/flex/core/ViewBase.as b/frameworks/as/src/org/apache/flex/core/ViewBase.as
index 91f569e..f9b96f1 100644
--- a/frameworks/as/src/org/apache/flex/core/ViewBase.as
+++ b/frameworks/as/src/org/apache/flex/core/ViewBase.as
@@ -22,6 +22,7 @@ package org.apache.flex.core
import org.apache.flex.events.Event;
import org.apache.flex.utils.MXMLDataInterpreter;
+ [Event(name="initComplete", type="org.apache.flex.events.Event")]
[DefaultProperty("mxmlContent")]
public class ViewBase extends UIBase
{
@@ -40,6 +41,8 @@ package org.apache.flex.core
MXMLDataInterpreter.generateMXMLProperties(this, MXMLProperties);
MXMLDataInterpreter.generateMXMLInstances(this, this, MXMLDescriptor);
+
+ dispatchEvent(new Event("initComplete"))
}
public function get MXMLDescriptor():Array
[6/6] git commit: [flex-asjs] - Merge branch 'develop' into
feature/createjs-checkbox
Posted by ca...@apache.org.
Merge branch 'develop' into feature/createjs-checkbox
# By Alex Harui (4) and Carlos Rovira (1)
* develop:
[CreateJS] fixed type coercion with flash.events.Event in Application
Selection Model should send selectedIndexChanged as well when selectedItem changed
add initComplete event sort of like creationComplete in current Flex SDK
Handle MXML views not having any styles
SimpleBinding must use flash.Events on the AS side for click and other mouse events
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/671e059e
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/671e059e
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/671e059e
Branch: refs/heads/feature/createjs-checkbox
Commit: 671e059eabdc153f2a0a56bd212c604596801929
Parents: a898de0 138cf91
Author: Carlos Rovira <ca...@apache.org>
Authored: Wed May 1 19:24:07 2013 +0200
Committer: Carlos Rovira <ca...@apache.org>
Committed: Wed May 1 19:24:07 2013 +0200
----------------------------------------------------------------------
.../src/org/apache/flex/binding/SimpleBinding.as | 5 +++--
.../org/apache/flex/core/SimpleCSSValuesImpl.as | 5 +++++
frameworks/as/src/org/apache/flex/core/ViewBase.as | 3 +++
.../as/src/org/apache/flex/createjs/Application.as | 2 +-
.../beads/models/ArraySelectionModel.as | 1 +
5 files changed, 13 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
[5/6] git commit: [flex-asjs] - [CreateJS] fixed type coercion with
flash.events.Event in Application
Posted by ca...@apache.org.
[CreateJS] fixed type coercion with flash.events.Event in Application
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/138cf91f
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/138cf91f
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/138cf91f
Branch: refs/heads/feature/createjs-checkbox
Commit: 138cf91f9b3b2f6fb1b8ab6f557e4318435c8ef7
Parents: cc79edb
Author: Carlos Rovira <ca...@apache.org>
Authored: Wed May 1 19:13:50 2013 +0200
Committer: Carlos Rovira <ca...@apache.org>
Committed: Wed May 1 19:13:50 2013 +0200
----------------------------------------------------------------------
.../as/src/org/apache/flex/createjs/Application.as | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/138cf91f/frameworks/as/src/org/apache/flex/createjs/Application.as
----------------------------------------------------------------------
diff --git a/frameworks/as/src/org/apache/flex/createjs/Application.as b/frameworks/as/src/org/apache/flex/createjs/Application.as
index 99f690d..a9fdfec 100644
--- a/frameworks/as/src/org/apache/flex/createjs/Application.as
+++ b/frameworks/as/src/org/apache/flex/createjs/Application.as
@@ -59,7 +59,7 @@ package org.apache.flex.createjs
loaderInfo.addEventListener(flash.events.Event.INIT, initHandler);
}
- private function initHandler(event:Event):void
+ private function initHandler(event:flash.events.Event):void
{
MXMLDataInterpreter.generateMXMLProperties(this, MXMLProperties);
[2/6] git commit: [flex-asjs] - Handle MXML views not having any
styles
Posted by ca...@apache.org.
Handle MXML views not having any styles
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/81a2aab8
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/81a2aab8
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/81a2aab8
Branch: refs/heads/feature/createjs-checkbox
Commit: 81a2aab88b930f1a7232841bb433a0387e7c7c87
Parents: 05632ae
Author: Alex Harui <ah...@apache.org>
Authored: Tue Apr 30 07:41:51 2013 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Tue Apr 30 07:41:51 2013 -0700
----------------------------------------------------------------------
.../org/apache/flex/core/SimpleCSSValuesImpl.as | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/81a2aab8/frameworks/as/src/org/apache/flex/core/SimpleCSSValuesImpl.as
----------------------------------------------------------------------
diff --git a/frameworks/as/src/org/apache/flex/core/SimpleCSSValuesImpl.as b/frameworks/as/src/org/apache/flex/core/SimpleCSSValuesImpl.as
index 129060e..dab5799 100644
--- a/frameworks/as/src/org/apache/flex/core/SimpleCSSValuesImpl.as
+++ b/frameworks/as/src/org/apache/flex/core/SimpleCSSValuesImpl.as
@@ -59,6 +59,11 @@ package org.apache.flex.core
public function generateCSSStyleDeclarations(factoryFunctions:Object, arr:Array):void
{
+ if (factoryFunctions == null)
+ return;
+ if (arr == null)
+ return;
+
var declarationName:String = "";
var segmentName:String = "";
var n:int = arr.length;
Re: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must use flash.Events on the AS side for click and other mouse events
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Why can't mustella generated files be in .gitignore?
Some of them could but not sure all as we might get conflicts with the same file endings we want to commit and those we don't (eg png or xml files).
I tried and was unable to make it work, if someone can get it to work that would be great.
Just do a build release, package up the SDK (add 11.7 FP and AIR 3.7 to it) and run some tests (the List test are currently broken so are a good candidate). You see there are several issues.
Justin
Re: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding
must use flash.Events on the AS side for click and other mouse events
Posted by Alex Harui <ah...@adobe.com>.
Why can't mustella generated files be in .gitignore?
On 5/1/13 3:31 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> Hi,
>
>> If this is what Fred has been warning us for, I'd give Fred +100 and
>> immediately vote to have all his suggestions be made the absolute rule.
>> This is a mess.
>
> Currently the workflow as suggested just doesn't work for me. If you do a
> release build or run any mustella tests it's then not possible to rebase the
> SDK. These unstagged changes are changes that you don't want to commit (test
> xml files or png files) or local changes to the XML config files (if you're
> using a different version of the FP for instance) and you can't add all to
> .gitignore.
>
> The only solution I can think off it to run tests, builds etc in a copy of the
> SDK but that makes the whole build, test, fix, commit cycle about twice as
> much work.
>
> Justin
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must use flash.Events on the AS side for click and other mouse events
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> If this is what Fred has been warning us for, I'd give Fred +100 and
> immediately vote to have all his suggestions be made the absolute rule.
> This is a mess.
Currently the workflow as suggested just doesn't work for me. If you do a release build or run any mustella tests it's then not possible to rebase the SDK. These unstagged changes are changes that you don't want to commit (test xml files or png files) or local changes to the XML config files (if you're using a different version of the FP for instance) and you can't add all to .gitignore.
The only solution I can think off it to run tests, builds etc in a copy of the SDK but that makes the whole build, test, fix, commit cycle about twice as much work.
Justin
Re: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must
use flash.Events on the AS side for click and other mouse events
Posted by Erik de Bruin <er...@ixsoftware.nl>.
If this is what Fred has been warning us for, I'd give Fred +100 and
immediately vote to have all his suggestions be made the absolute rule.
This is a mess.
EdB
On Wednesday, May 1, 2013, Kessler CTR Mark J wrote:
> I think it happens when the next person who is going to commit something
> does a pull instead of a fetch/rebase before doing their next push. Not
> 100% positive though... Although if you look through a git log you can
> see it break out a bit.
>
> Justin is so active he does it to all of mine :P
>
> -Mark
>
>
> -----Original Message-----
> From: Alex Harui [mailto:aharui@adobe.com <javascript:;>]
> Sent: Wednesday, May 01, 2013 1:52 PM
> To: dev@flex.apache.org <javascript:;>; commits@flex.apache.org<javascript:;>
> Subject: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must
> use flash.Events on the AS side for click and other mouse events
>
> Can someone explain why Carlos's checkin also provided notifications for my
> last set of checkins, but under his name? And why is that a good thing?
>
> Thanks,
> -Alex
>
>
> On 5/1/13 10:25 AM, "carlosrovira@apache.org <javascript:;>" <
> carlosrovira@apache.org <javascript:;>>
> wrote:
>
> > Updated Branches:
> > refs/heads/feature/createjs-checkbox a898de058 -> 671e059ea
> >
> >
> > SimpleBinding must use flash.Events on the AS side for click and other
> mouse
> > events
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/05632ae9
> > Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/05632ae9
> > Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/05632ae9
> >
> > Branch: refs/heads/feature/createjs-checkbox
> > Commit: 05632ae947411f0c47770c0be99497a9447d3697
> > Parents: 128e84c
> > Author: Alex Harui <aharui@apache.org <javascript:;>>
> > Authored: Tue Apr 30 07:41:15 2013 -0700
> > Committer: Alex Harui <aharui@apache.org <javascript:;>>
> > Committed: Tue Apr 30 07:41:15 2013 -0700
> >
> > ----------------------------------------------------------------------
> > .../src/org/apache/flex/binding/SimpleBinding.as | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/05632ae9/frameworks/as/s
> > rc/org/apache/flex/binding/SimpleBinding.as
> > ----------------------------------------------------------------------
> > diff --git a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> > b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> > index c5bd392..6e5a72a 100644
> > --- a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> > +++ b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> > @@ -18,11 +18,12 @@
> >
> >
> //////////////////////////////////////////////////////////////////////////////
> > //
> > package org.apache.flex.binding
> > {
> > + import flash.events.IEventDispatcher;
> > + import flash.events.Event;
> > +
> > import org.apache.flex.core.IBead;
> > import org.apache.flex.core.IStrand;
> > import org.apache.flex.core.IDocument;
> > - import org.apache.flex.events.Event;
> > - import org.apache.flex.events.IEventDispatcher;
> >
> > public class SimpleBinding implements IBead, IDocument
> > {
> >
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must use flash.Events on the AS side for click and other mouse events
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I think it happens when the next person who is going to commit something does a pull instead of a fetch/rebase before doing their next push.
Isn't it the other way around as a rebase rewrites commits?
Justin
RE: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must use flash.Events on the AS side for click and other mouse events
Posted by Kessler CTR Mark J <ma...@usmc.mil>.
I think it happens when the next person who is going to commit something does a pull instead of a fetch/rebase before doing their next push. Not 100% positive though... Although if you look through a git log you can see it break out a bit.
Justin is so active he does it to all of mine :P
-Mark
-----Original Message-----
From: Alex Harui [mailto:aharui@adobe.com]
Sent: Wednesday, May 01, 2013 1:52 PM
To: dev@flex.apache.org; commits@flex.apache.org
Subject: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must use flash.Events on the AS side for click and other mouse events
Can someone explain why Carlos's checkin also provided notifications for my
last set of checkins, but under his name? And why is that a good thing?
Thanks,
-Alex
On 5/1/13 10:25 AM, "carlosrovira@apache.org" <ca...@apache.org>
wrote:
> Updated Branches:
> refs/heads/feature/createjs-checkbox a898de058 -> 671e059ea
>
>
> SimpleBinding must use flash.Events on the AS side for click and other mouse
> events
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/05632ae9
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/05632ae9
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/05632ae9
>
> Branch: refs/heads/feature/createjs-checkbox
> Commit: 05632ae947411f0c47770c0be99497a9447d3697
> Parents: 128e84c
> Author: Alex Harui <ah...@apache.org>
> Authored: Tue Apr 30 07:41:15 2013 -0700
> Committer: Alex Harui <ah...@apache.org>
> Committed: Tue Apr 30 07:41:15 2013 -0700
>
> ----------------------------------------------------------------------
> .../src/org/apache/flex/binding/SimpleBinding.as | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/05632ae9/frameworks/as/s
> rc/org/apache/flex/binding/SimpleBinding.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> index c5bd392..6e5a72a 100644
> --- a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> +++ b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> @@ -18,11 +18,12 @@
>
> //////////////////////////////////////////////////////////////////////////////
> //
> package org.apache.flex.binding
> {
> + import flash.events.IEventDispatcher;
> + import flash.events.Event;
> +
> import org.apache.flex.core.IBead;
> import org.apache.flex.core.IStrand;
> import org.apache.flex.core.IDocument;
> - import org.apache.flex.events.Event;
> - import org.apache.flex.events.IEventDispatcher;
>
> public class SimpleBinding implements IBead, IDocument
> {
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding
must use flash.Events on the AS side for click and other mouse events
Posted by Alex Harui <ah...@adobe.com>.
Ah thanks. I keep forgetting to look at the top of the commit.
On 5/1/13 11:31 AM, "Dasa Paddock" <dp...@esri.com> wrote:
> In commit 671e059ea, Carlos merged the commits from the "develop" branch into
> the "feature/createjs-checkbox" branch.
>
> This is easier to see in a GUI, but here's what's shown for this commit at:
> https://git-wip-us.apache.org/repos/asf?p=flex-asjs.git;a=commit;h=671e059eabd
> c153f2a0a56bd212c604596801929
>
> --Dasa
>
> On May 1, 2013, at 10:51 AM, Alex Harui <ah...@adobe.com> wrote:
>
>> Can someone explain why Carlos's checkin also provided notifications for my
>> last set of checkins, but under his name? And why is that a good thing?
>>
>> Thanks,
>> -Alex
>>
>>
>> On 5/1/13 10:25 AM, "carlosrovira@apache.org" <ca...@apache.org>
>> wrote:
>>
>>> Updated Branches:
>>> refs/heads/feature/createjs-checkbox a898de058 -> 671e059ea
>>>
>>>
>>> SimpleBinding must use flash.Events on the AS side for click and other mouse
>>> events
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/05632ae9
>>> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/05632ae9
>>> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/05632ae9
>>>
>>> Branch: refs/heads/feature/createjs-checkbox
>>> Commit: 05632ae947411f0c47770c0be99497a9447d3697
>>> Parents: 128e84c
>>> Author: Alex Harui <ah...@apache.org>
>>> Authored: Tue Apr 30 07:41:15 2013 -0700
>>> Committer: Alex Harui <ah...@apache.org>
>>> Committed: Tue Apr 30 07:41:15 2013 -0700
>>>
>>> ----------------------------------------------------------------------
>>> .../src/org/apache/flex/binding/SimpleBinding.as | 5 +++--
>>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/05632ae9/frameworks/as
>>> /s
>>> rc/org/apache/flex/binding/SimpleBinding.as
>>> ----------------------------------------------------------------------
>>> diff --git a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
>>> b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
>>> index c5bd392..6e5a72a 100644
>>> --- a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
>>> +++ b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
>>> @@ -18,11 +18,12 @@
>>>
>>> ////////////////////////////////////////////////////////////////////////////
>>> //
>>> //
>>> package org.apache.flex.binding
>>> {
>>> + import flash.events.IEventDispatcher;
>>> + import flash.events.Event;
>>> +
>>> import org.apache.flex.core.IBead;
>>> import org.apache.flex.core.IStrand;
>>> import org.apache.flex.core.IDocument;
>>> - import org.apache.flex.events.Event;
>>> - import org.apache.flex.events.IEventDispatcher;
>>>
>>> public class SimpleBinding implements IBead, IDocument
>>> {
>>>
>>
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui
>>
>>
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding
must use flash.Events on the AS side for click and other mouse events
Posted by Dasa Paddock <dp...@esri.com>.
In commit 671e059ea, Carlos merged the commits from the "develop" branch into the "feature/createjs-checkbox" branch.
This is easier to see in a GUI, but here's what's shown for this commit at:
https://git-wip-us.apache.org/repos/asf?p=flex-asjs.git;a=commit;h=671e059eabdc153f2a0a56bd212c604596801929
--Dasa
On May 1, 2013, at 10:51 AM, Alex Harui <ah...@adobe.com> wrote:
> Can someone explain why Carlos's checkin also provided notifications for my
> last set of checkins, but under his name? And why is that a good thing?
>
> Thanks,
> -Alex
>
>
> On 5/1/13 10:25 AM, "carlosrovira@apache.org" <ca...@apache.org>
> wrote:
>
>> Updated Branches:
>> refs/heads/feature/createjs-checkbox a898de058 -> 671e059ea
>>
>>
>> SimpleBinding must use flash.Events on the AS side for click and other mouse
>> events
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/05632ae9
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/05632ae9
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/05632ae9
>>
>> Branch: refs/heads/feature/createjs-checkbox
>> Commit: 05632ae947411f0c47770c0be99497a9447d3697
>> Parents: 128e84c
>> Author: Alex Harui <ah...@apache.org>
>> Authored: Tue Apr 30 07:41:15 2013 -0700
>> Committer: Alex Harui <ah...@apache.org>
>> Committed: Tue Apr 30 07:41:15 2013 -0700
>>
>> ----------------------------------------------------------------------
>> .../src/org/apache/flex/binding/SimpleBinding.as | 5 +++--
>> 1 files changed, 3 insertions(+), 2 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/05632ae9/frameworks/as/s
>> rc/org/apache/flex/binding/SimpleBinding.as
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
>> b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
>> index c5bd392..6e5a72a 100644
>> --- a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
>> +++ b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
>> @@ -18,11 +18,12 @@
>>
>> //////////////////////////////////////////////////////////////////////////////
>> //
>> package org.apache.flex.binding
>> {
>> + import flash.events.IEventDispatcher;
>> + import flash.events.Event;
>> +
>> import org.apache.flex.core.IBead;
>> import org.apache.flex.core.IStrand;
>> import org.apache.flex.core.IDocument;
>> - import org.apache.flex.events.Event;
>> - import org.apache.flex.events.IEventDispatcher;
>>
>> public class SimpleBinding implements IBead, IDocument
>> {
>>
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>
>
[GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must
use flash.Events on the AS side for click and other mouse events
Posted by Alex Harui <ah...@adobe.com>.
Can someone explain why Carlos's checkin also provided notifications for my
last set of checkins, but under his name? And why is that a good thing?
Thanks,
-Alex
On 5/1/13 10:25 AM, "carlosrovira@apache.org" <ca...@apache.org>
wrote:
> Updated Branches:
> refs/heads/feature/createjs-checkbox a898de058 -> 671e059ea
>
>
> SimpleBinding must use flash.Events on the AS side for click and other mouse
> events
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/05632ae9
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/05632ae9
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/05632ae9
>
> Branch: refs/heads/feature/createjs-checkbox
> Commit: 05632ae947411f0c47770c0be99497a9447d3697
> Parents: 128e84c
> Author: Alex Harui <ah...@apache.org>
> Authored: Tue Apr 30 07:41:15 2013 -0700
> Committer: Alex Harui <ah...@apache.org>
> Committed: Tue Apr 30 07:41:15 2013 -0700
>
> ----------------------------------------------------------------------
> .../src/org/apache/flex/binding/SimpleBinding.as | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/05632ae9/frameworks/as/s
> rc/org/apache/flex/binding/SimpleBinding.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> index c5bd392..6e5a72a 100644
> --- a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> +++ b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> @@ -18,11 +18,12 @@
>
> //////////////////////////////////////////////////////////////////////////////
> //
> package org.apache.flex.binding
> {
> + import flash.events.IEventDispatcher;
> + import flash.events.Event;
> +
> import org.apache.flex.core.IBead;
> import org.apache.flex.core.IStrand;
> import org.apache.flex.core.IDocument;
> - import org.apache.flex.events.Event;
> - import org.apache.flex.events.IEventDispatcher;
>
> public class SimpleBinding implements IBead, IDocument
> {
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
[GIT] was Re: [1/6] git commit: [flex-asjs] - SimpleBinding must
use flash.Events on the AS side for click and other mouse events
Posted by Alex Harui <ah...@adobe.com>.
Can someone explain why Carlos's checkin also provided notifications for my
last set of checkins, but under his name? And why is that a good thing?
Thanks,
-Alex
On 5/1/13 10:25 AM, "carlosrovira@apache.org" <ca...@apache.org>
wrote:
> Updated Branches:
> refs/heads/feature/createjs-checkbox a898de058 -> 671e059ea
>
>
> SimpleBinding must use flash.Events on the AS side for click and other mouse
> events
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/05632ae9
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/05632ae9
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/05632ae9
>
> Branch: refs/heads/feature/createjs-checkbox
> Commit: 05632ae947411f0c47770c0be99497a9447d3697
> Parents: 128e84c
> Author: Alex Harui <ah...@apache.org>
> Authored: Tue Apr 30 07:41:15 2013 -0700
> Committer: Alex Harui <ah...@apache.org>
> Committed: Tue Apr 30 07:41:15 2013 -0700
>
> ----------------------------------------------------------------------
> .../src/org/apache/flex/binding/SimpleBinding.as | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/05632ae9/frameworks/as/s
> rc/org/apache/flex/binding/SimpleBinding.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> index c5bd392..6e5a72a 100644
> --- a/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> +++ b/frameworks/as/src/org/apache/flex/binding/SimpleBinding.as
> @@ -18,11 +18,12 @@
>
> //////////////////////////////////////////////////////////////////////////////
> //
> package org.apache.flex.binding
> {
> + import flash.events.IEventDispatcher;
> + import flash.events.Event;
> +
> import org.apache.flex.core.IBead;
> import org.apache.flex.core.IStrand;
> import org.apache.flex.core.IDocument;
> - import org.apache.flex.events.Event;
> - import org.apache.flex.events.IEventDispatcher;
>
> public class SimpleBinding implements IBead, IDocument
> {
>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui