You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "SBIN2010 (via GitHub)" <gi...@apache.org> on 2025/10/29 12:28:50 UTC
[PR] fix: displaying sell bars in table [superset]
SBIN2010 opened a new pull request, #35885:
URL: https://github.com/apache/superset/pull/35885
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR restores the display of cell bars in table
The token comes in RGBA format, not HEX.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
BEFORE
<img width="2182" height="785" alt="Снимок экрана от 2025-10-29 15-19-34" src="https://github.com/user-attachments/assets/928af2cb-a36f-4e37-8f66-920a449aec5d" />
AFTER
<img width="2182" height="785" alt="Снимок экрана от 2025-10-29 15-18-07" src="https://github.com/user-attachments/assets/063c33d0-1e28-4ad6-9769-5bd6e7b231a4" />
<img width="2182" height="785" alt="Снимок экрана от 2025-10-29 15-18-37" src="https://github.com/user-attachments/assets/6bc59944-8ed7-4268-82a9-c6d34d21b16f" />
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: displaying sell bars in table [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #35885:
URL: https://github.com/apache/superset/pull/35885#issuecomment-3461309472
<details open>
<summary><strong>Interaction Diagram by <a href="https://bito.ai#sequence_diagram">Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant ChartPlugin as ChartPlugin<br/>🔄 Updated | ●●○ Medium
participant TableChart as TableChart Component
participant CellRenderer as Cell Renderer
participant ColorFunc as cellBackground()
participant Theme as Theme Object
Note over ColorFunc: Changed color logic<br/>colorFillSecondary→colorFill
ChartPlugin->>TableChart: Load chart with data
TableChart->>CellRenderer: Render table cells
CellRenderer->>ColorFunc: Get cell background color
ColorFunc->>Theme: Query colorFill token
Theme-->>ColorFunc: Return color value
ColorFunc-->>CellRenderer: Apply background style
CellRenderer-->>TableChart: Render styled cell bar
```
Critical path: ChartPlugin->TableChart Component->Cell Renderer->cellBackground()->Theme Object
> **Note:** The cellBackground function now uses theme.colorFill (solid) instead of theme.colorFillSecondary with 50% transparency when colorPositiveNegative is false. This change affects cell bar styling in table visualizations, making them more visually prominent and consistent with the primary theme color scheme.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: displaying cell bars in table [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #35885:
URL: https://github.com/apache/superset/pull/35885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: displaying sell bars in table [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #35885:
URL: https://github.com/apache/superset/pull/35885#issuecomment-3461262244
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org