You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sean Lin (JIRA)" <ji...@apache.org> on 2012/08/23 11:49:42 UTC
[jira] [Created] (WICKET-4727) ThreadContext should be detached
before each subscribed page gets notified
Sean Lin created WICKET-4727:
--------------------------------
Summary: ThreadContext should be detached before each subscribed page gets notified
Key: WICKET-4727
URL: https://issues.apache.org/jira/browse/WICKET-4727
Project: Wicket
Issue Type: Bug
Components: wicket-atmosphere
Affects Versions: 6.0.0-beta3
Reporter: Sean Lin
Assignee: Emond Papegaaij
Since the event subscriptions may cross different sessions, before entering request cycles of notified page, the ThreadContext should be detached except application instance.
In EventBus#post(Object event), ThreadContext.detach() should be placed inside the for-loop block of atmosphere resources,
otherwise Session().get() may return previous page's session.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4727) ThreadContext should be detached
before each subscribed page gets notified
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij resolved WICKET-4727.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
Good catch. I've replaced restore(null) with detach, moved it inside the loop, and removed the redundant detach at the end of the loop.
> ThreadContext should be detached before each subscribed page gets notified
> --------------------------------------------------------------------------
>
> Key: WICKET-4727
> URL: https://issues.apache.org/jira/browse/WICKET-4727
> Project: Wicket
> Issue Type: Bug
> Components: wicket-atmosphere
> Affects Versions: 6.0.0-beta3
> Reporter: Sean Lin
> Assignee: Emond Papegaaij
> Fix For: 6.0.0
>
>
> Since the event subscriptions may cross different sessions, before entering request cycles of notified page, the ThreadContext should be detached except application instance.
> In EventBus#post(Object event), ThreadContext.detach() should be placed inside the for-loop block of atmosphere resources,
> otherwise Session().get() may return previous page's session.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira