[jira] [Commented] (AMBARI-6060) amabri-web project build should fail if brunch build or gzip command execution fails

["Jaimin D Jetly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025531#comment-14025531 ] 

Jaimin D Jetly commented on AMBARI-6060:
----------------------------------------

As a resolution to this ticket, I feel we should remove failonerror flag for all commands.
This will make maven complile command executed from ambari project root directory fail if node and npm is not installed on the machine. May be we had failonerror flag set to true for this reason. 

> amabri-web project build should fail if brunch build or gzip command execution fails
> ------------------------------------------------------------------------------------
>
>                 Key: AMBARI-6060
>                 URL: https://issues.apache.org/jira/browse/AMBARI-6060
>             Project: Ambari
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.1
>            Reporter: Jaimin D Jetly
>            Assignee: Jaimin D Jetly
>             Fix For: 1.6.1
>
>         Attachments: AMBARI-6060.patch
>
>
> currently even if brunch build command or gzip command fails, ambari-we build does not fail-fast due to {{failonerror}} flag set to false
> {code}
>  <exec dir="${basedir}" executable="brunch" failonerror="false">
>                   <arg value="build"/>
>                 </exec>
> <exec dir="${basedir}" executable="gzip" failonerror="false">
>                   <arg value="public/javascripts/app.js"/>
>                   <arg value="public/javascripts/vendor.js"/>
>                   <arg value="public/stylesheets/app.css"/>
>                 </exec>
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)