[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #10544: fix dubbo proxyless xds connect, fix Connection closed after GOAWAY, …

[GitBox <gi...@apache.org>]

AlbumenJ commented on code in PR #10544:
URL: https://github.com/apache/dubbo/pull/10544#discussion_r963222625


##########
dubbo-xds/src/main/java/org/apache/dubbo/registry/xds/util/protocol/AbstractProtocol.java:
##########
@@ -231,6 +231,8 @@ public void onNext(DiscoveryResponse value) {
         @Override
         public void onError(Throwable t) {
             logger.error("xDS Client received error message! detail:", t);
+            StreamObserver<DiscoveryRequest> requestObserver = xdsChannel.createDeltaDiscoveryRequest(new ResponseObserver(requestId));
+            requestObserverMap.put(requestId, requestObserver);

Review Comment:
   这里需要检查下 Throwable 的类型，同时做下重试的速率限制



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org