You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/01 15:33:02 UTC
[GitHub] [arrow-datafusion] xudong963 opened a new pull request #1720: Substitute `parking_lot::Mutex` for `std::sync::Mutex`
xudong963 opened a new pull request #1720:
URL: https://github.com/apache/arrow-datafusion/pull/1720
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
As the title.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I did a simple benchmark and found there are some performance improvements.
| query | parking_lot::Mutex | std::sync::Mutex |
| ---- | ---- | ---- |
| 1 | 2889.14 ms | 2881.76 ms|
| 3 | 3047.44 ms |3079.82 ms|
| 5|2714.37 ms|2816.34 ms|
|6| 2469.22 ms|2529.96 ms|
|7| 4127.99 ms|4176.91 ms|
|10| 2664.02 ms|2806.26 ms|
|12|3519.28 ms|3580.24 ms|
|13| 728.52 ms|845.60 ms|
cc @alamb @houqp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on pull request #1720: substitute `parking_lot::Mutex` for `std::sync::Mutex`
Posted by GitBox <gi...@apache.org>.
xudong963 commented on pull request #1720:
URL: https://github.com/apache/arrow-datafusion/pull/1720#issuecomment-1027633732
Me too @Dandandan @alamb. I'll do the performance analysis and find the performance-critical areas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on pull request #1720: substitute `parking_lot::Mutex` for `std::sync::Mutex`
Posted by GitBox <gi...@apache.org>.
xudong963 commented on pull request #1720:
URL: https://github.com/apache/arrow-datafusion/pull/1720#issuecomment-1026997170
**cause**: I just I'm just wondering if `parking_lot` is really fast 😄 if really, I'll dig into it.
**procedure**: I use DF to do an experiment to verify my curiosity.
**result**: Performance has really improved, so I think we can use it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1720: substitute `parking_lot::Mutex` for `std::sync::Mutex`
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1720:
URL: https://github.com/apache/arrow-datafusion/pull/1720#issuecomment-1027839887
Thanks again @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #1720: substitute `parking_lot::Mutex` for `std::sync::Mutex`
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #1720:
URL: https://github.com/apache/arrow-datafusion/pull/1720#issuecomment-1027020644
Interesting, wasn't expecting we are using mutexes in performance critical areas - maybe that's also something to look into.
If we go down the route of using `parking_lot`, something to consider is also enabling the feature for `tokio`.
https://docs.rs/tokio/latest/tokio/#internal-features
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1720: substitute `parking_lot::Mutex` for `std::sync::Mutex`
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1720:
URL: https://github.com/apache/arrow-datafusion/pull/1720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org