[jira] Commented: (HARMONY-6481) Failure to retrieve the command line parameters via procfs causes NPE

["Mark Hindess (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848622#action_12848622 ] 

Mark Hindess commented on HARMONY-6481:
---------------------------------------

Thanks Mark.

If you plan to contribute further patches, could you possibly take a look at the contriubtion policy and file an ACQ (and ICLA if you haven't already)?

Looks like your patch conflicts with Ilya's commit r926414:

  http://svn.apache.org/viewvc?rev=926414&view=rev
  Fix crashes in crash handler when /proc is not mounted

I suspect Ilya's commit covers most of the issues in which case please confirm this by closing this JIRA.  Otherwise, please attach a new patch.

Thanks,
 Mark.


> Failure to retrieve the command line parameters via procfs causes NPE
> ---------------------------------------------------------------------
>
>                 Key: HARMONY-6481
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6481
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: operating system :  FreeBSD [8.0p2]
> CPU architecture :  x86
> ant os name/arch :  FreeBSD/i386
> hosting Java     :  1.6.0_07 (The FreeBSD Foundation)
>            Reporter: Mark Eschbach
>         Attachments: harmony-drlvm-ch-cmdln.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> If the crash handler fails to open the procfs file relating to the command line then this will leave a variable (g_cmdline) in the default state of NULL.  Upon rendering a crash report, the variable is not checked for being NULL and will cause the crash report deference a NULL pointer.
> I'm not sure if you may unmount procfs on Linux, if you may move the procfs mount point from /proc, nor under which conditions opening the current process's command line would fail.  Under FreeBSD (by default) doesn't have procfs mounted, and to mount procfs is generally considered an excessive security risk.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.