[GitHub] [flink] KurtYoung commented on issue #9185: [FLINK-13266] [table] Relocate blink planner classes to avoid class clashes

[GitBox <gi...@apache.org>]

KurtYoung commented on issue #9185: [FLINK-13266] [table] Relocate blink planner classes to avoid class clashes
URL: https://github.com/apache/flink/pull/9185#issuecomment-514018888
 
 
   > Some general feedback regarding `ExecutionConfigOptions`. We are now moving it to the API module. We should actually discuss how the properties are named and make sure that those options follow Flink naming conventions. Right now, I see `sql.exec.sort.file-handles.num.max` which should be renamed to `sql.exec.sort.max-num-file-handles` instead of `sql.exec.sort.file-handles.num.max`. Or `sql.exec.window-agg.buffer-size-limit` instead of `sql.exec.window-agg.buffer-size.limit`. When do we plan to do that? @wuchong @godfreyhe
   
   Thanks for the suggestion. I think now is the good time to adjust the naming since the config name should also be treated as public API. Once we released this, it's very difficult to modify them. BTW, do you have any example which can reflect the flink naming conventions that we can refer to?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services